Skip to content

Commit 9741f5f

Browse files
author
Jaideep Bajwa
committed
deps: cherry-pick 7c982e7 from V8 upstream
Original commit message: PPC/s390: [Turbofan]: Use new MachineTypes in access-builder. Port 56429fc14671a10749190a4dfeacd38b7270f6f5 Original Commit Message: Introduced MachineType::TaggedSigned() and TaggedPointer(). The idea is to quit using the representational dimension of Type, and instead encode this information in the MachineRepresentation (itself lightly wrapped in MachineType, along with MachineSemantic). There are three parts to the whole change: 1) Places that set the machine representation - constant nodes, loads nad stores, global object and native context specialization. 2) Places that propagate type/representation - this is representation inference (aka simplified lowering). At the end of this process we expect to have a MachineRepresentation for every node. An interesting part of this is phi merging. 3) Places that examine representation - WriteBarrier elimination does this. Currently it's looking at the Type representation dimension, but as a part of this change (or in a soon-to-follow change) it can simply examine the MachineRepresentation. [email protected], [email protected], [email protected], [email protected] BUG= LOG=N Review-Url: https://codereview.chromium.org/2662223003 Cr-Commit-Position: refs/heads/master@{#42817}
1 parent 2f1ce29 commit 9741f5f

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

deps/v8/include/v8-version.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
#define V8_MAJOR_VERSION 5
1212
#define V8_MINOR_VERSION 5
1313
#define V8_BUILD_NUMBER 372
14-
#define V8_PATCH_LEVEL 40
14+
#define V8_PATCH_LEVEL 41
1515

1616
// Use 1 for candidates and 0 otherwise.
1717
// (Boolean macro values are not supported by all preprocessors.)

deps/v8/src/compiler/ppc/instruction-selector-ppc.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ void InstructionSelector::VisitStore(Node* node) {
245245
MachineRepresentation rep = store_rep.representation();
246246

247247
if (write_barrier_kind != kNoWriteBarrier) {
248-
DCHECK_EQ(MachineRepresentation::kTagged, rep);
248+
DCHECK(CanBeTaggedPointer(rep));
249249
AddressingMode addressing_mode;
250250
InstructionOperand inputs[3];
251251
size_t input_count = 0;

deps/v8/src/compiler/s390/instruction-selector-s390.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,7 @@ void InstructionSelector::VisitStore(Node* node) {
343343
MachineRepresentation rep = store_rep.representation();
344344

345345
if (write_barrier_kind != kNoWriteBarrier) {
346-
DCHECK_EQ(MachineRepresentation::kTagged, rep);
346+
DCHECK(CanBeTaggedPointer(rep));
347347
AddressingMode addressing_mode;
348348
InstructionOperand inputs[3];
349349
size_t input_count = 0;

0 commit comments

Comments
 (0)