Skip to content

Commit 97547bc

Browse files
kapouerRafaelGSS
authored andcommitted
src: lock-free init_process_flags
Fix #45152 PR-URL: #45221 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
1 parent 738144c commit 97547bc

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

src/node.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -429,7 +429,7 @@ void ResetSignalHandlers() {
429429
#endif // __POSIX__
430430
}
431431

432-
static std::atomic<uint64_t> init_process_flags = 0;
432+
static std::atomic<uint32_t> init_process_flags = 0;
433433

434434
static void PlatformInit(ProcessInitializationFlags::Flags flags) {
435435
// init_process_flags is accessed in ResetStdio(),

src/node.h

+2
Original file line numberDiff line numberDiff line change
@@ -228,6 +228,8 @@ class MultiIsolatePlatform;
228228
class InitializationResultImpl;
229229

230230
namespace ProcessFlags {
231+
// TODO(addaleax): Switch to uint32_t to match std::atomic<uint32_t>
232+
// init_process_flags in node.cc
231233
enum Flags : uint64_t {
232234
kNoFlags = 0,
233235
// Enable stdio inheritance, which is disabled by default.

0 commit comments

Comments
 (0)