Skip to content

Commit 986e1d2

Browse files
committed
deps: cherry-pick f5fad6d from upstream v8
Original commit message: This commit adds a getter for the private is_verbose_ member. The use case for this comes from Node.js where the ability to avoid calling FatalException if the TryCatch is verbose would be nice to have. BUG= Review-Url: https://codereview.chromium.org/2840803002 Cr-Commit-Position: refs/heads/master@{#45018} PR-URL: #12826 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
1 parent 0c2edd2 commit 986e1d2

File tree

3 files changed

+10
-1
lines changed

3 files changed

+10
-1
lines changed

deps/v8/include/v8-version.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
#define V8_MAJOR_VERSION 5
1212
#define V8_MINOR_VERSION 8
1313
#define V8_BUILD_NUMBER 283
14-
#define V8_PATCH_LEVEL 38
14+
#define V8_PATCH_LEVEL 39
1515

1616
// Use 1 for candidates and 0 otherwise.
1717
// (Boolean macro values are not supported by all preprocessors.)

deps/v8/include/v8.h

+5
Original file line numberDiff line numberDiff line change
@@ -7982,6 +7982,11 @@ class V8_EXPORT TryCatch {
79827982
*/
79837983
void SetVerbose(bool value);
79847984

7985+
/**
7986+
* Returns true if verbosity is enabled.
7987+
*/
7988+
bool IsVerbose() const;
7989+
79857990
/**
79867991
* Set whether or not this TryCatch should capture a Message object
79877992
* which holds source information about where the exception

deps/v8/src/api.cc

+4
Original file line numberDiff line numberDiff line change
@@ -2691,6 +2691,10 @@ void v8::TryCatch::SetVerbose(bool value) {
26912691
is_verbose_ = value;
26922692
}
26932693

2694+
bool v8::TryCatch::IsVerbose() const {
2695+
return is_verbose_;
2696+
}
2697+
26942698

26952699
void v8::TryCatch::SetCaptureMessage(bool value) {
26962700
capture_message_ = value;

0 commit comments

Comments
 (0)