Skip to content

Commit 98963f2

Browse files
telenordtargos
telenord
authored andcommitted
http: revise _http_server.js
* replace var with const * eliminate unnecessary bytesParsed variable http: remove bytesParsed var PR-URL: #30279 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Yorkie Liu <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 376ec01 commit 98963f2

File tree

1 file changed

+10
-11
lines changed

1 file changed

+10
-11
lines changed

lib/_http_server.js

+10-11
Original file line numberDiff line numberDiff line change
@@ -253,13 +253,13 @@ function writeHead(statusCode, reason, obj) {
253253
}
254254
this.statusCode = statusCode;
255255

256-
var headers;
256+
let headers;
257257
if (this[kOutHeaders]) {
258258
// Slow-case: when progressive API and header fields are passed.
259-
var k;
259+
let k;
260260
if (obj) {
261-
var keys = Object.keys(obj);
262-
for (var i = 0; i < keys.length; i++) {
261+
const keys = Object.keys(obj);
262+
for (let i = 0; i < keys.length; i++) {
263263
k = keys[i];
264264
if (k) this.setHeader(k, obj[k]);
265265
}
@@ -487,7 +487,7 @@ function socketOnClose(socket, state) {
487487

488488
function abortIncoming(incoming) {
489489
while (incoming.length) {
490-
var req = incoming.shift();
490+
const req = incoming.shift();
491491
req.aborted = true;
492492
req.emit('aborted');
493493
req.emit('close');
@@ -577,8 +577,7 @@ function onParserExecuteCommon(server, socket, parser, state, ret, d) {
577577
socketOnError.call(socket, ret);
578578
} else if (parser.incoming && parser.incoming.upgrade) {
579579
// Upgrade or CONNECT
580-
var bytesParsed = ret;
581-
var req = parser.incoming;
580+
const req = parser.incoming;
582581
debug('SERVER upgrade or connect', req.method);
583582

584583
if (!d)
@@ -594,10 +593,10 @@ function onParserExecuteCommon(server, socket, parser, state, ret, d) {
594593
freeParser(parser, req, socket);
595594
parser = null;
596595

597-
var eventName = req.method === 'CONNECT' ? 'connect' : 'upgrade';
596+
const eventName = req.method === 'CONNECT' ? 'connect' : 'upgrade';
598597
if (eventName === 'upgrade' || server.listenerCount(eventName) > 0) {
599598
debug('SERVER have listener for %s', eventName);
600-
var bodyHead = d.slice(bytesParsed, d.length);
599+
const bodyHead = d.slice(ret, d.length);
601600

602601
socket.readableFlowing = null;
603602
server.emit(eventName, req, socket, bodyHead);
@@ -659,7 +658,7 @@ function resOnFinish(req, res, socket, state, server) {
659658
}
660659
} else {
661660
// Start sending the next message
662-
var m = state.outgoing.shift();
661+
const m = state.outgoing.shift();
663662
if (m) {
664663
m.assignSocket(socket);
665664
}
@@ -696,7 +695,7 @@ function parserOnIncoming(server, socket, state, req, keepAlive) {
696695
// so that we don't become overwhelmed by a flood of
697696
// pipelined requests that may never be resolved.
698697
if (!socket._paused) {
699-
var ws = socket._writableState;
698+
const ws = socket._writableState;
700699
if (ws.needDrain || state.outgoingData >= socket.writableHighWaterMark) {
701700
socket._paused = true;
702701
// We also need to pause the parser, but don't do that until after

0 commit comments

Comments
 (0)