Skip to content

Commit 9968941

Browse files
targosAli Sheikh
authored and
Ali Sheikh
committed
test: fix tests after V8 upgrade
- An error message changed for undefined references - `let` is now allowed in sloppy mode - ES2015 proxies are shipped and the `Proxy` global is now a function PR-URL: #4722 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]>
1 parent 079973b commit 9968941

File tree

4 files changed

+4
-8
lines changed

4 files changed

+4
-8
lines changed

test/message/timeout_throw.out

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@
22
undefined_reference_error_maker;
33
^
44
ReferenceError: undefined_reference_error_maker is not defined
5-
at null._onTimeout (*test*message*timeout_throw.js:*:*)
5+
at ._onTimeout (*test*message*timeout_throw.js:*:*)
66
at tryOnTimeout (timers.js:*:*)
77
at Timer.listOnTimeout (timers.js:*:*)

test/parallel/test-repl-mode.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,7 @@ function testSloppyMode() {
2828
cli.input.emit('data', `
2929
let y = 3
3030
`.trim() + '\n');
31-
assert.ok(/SyntaxError: Block-scoped/.test(
32-
cli.output.accumulator.join('')));
31+
assert.equal(cli.output.accumulator.join(''), 'undefined\n> ');
3332
}
3433

3534
function testStrictMode() {

test/parallel/test-repl-tab-complete.js

-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
'use strict';
22

3-
// Flags: --harmony-proxies
4-
53
var common = require('../common');
64
var assert = require('assert');
75
var repl = require('repl');
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
'use strict';
2-
// Flags: --harmony_proxies
32

43
require('../common');
54
var assert = require('assert');
@@ -9,11 +8,11 @@ var vm = require('vm');
98
// context. Make sure that the new context has a Proxy object of its own.
109
var sandbox = {};
1110
vm.runInNewContext('this.Proxy = Proxy', sandbox);
12-
assert(typeof sandbox.Proxy === 'object');
11+
assert(typeof sandbox.Proxy === 'function');
1312
assert(sandbox.Proxy !== Proxy);
1413

1514
// Unless we copy the Proxy object explicitly, of course.
1615
sandbox = { Proxy: Proxy };
1716
vm.runInNewContext('this.Proxy = Proxy', sandbox);
18-
assert(typeof sandbox.Proxy === 'object');
17+
assert(typeof sandbox.Proxy === 'function');
1918
assert(sandbox.Proxy === Proxy);

0 commit comments

Comments
 (0)