Skip to content

Commit 997204a

Browse files
targosaddaleax
authored andcommitted
src: fix new V8 compiler warnings
Backport-PR-URL: #14574 Backport-Reviewed-By: Anna Henningsen <[email protected]> Backport-Reviewed-By: Refael Ackermann <[email protected]> PR-URL: #14004 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
1 parent 2dbf95d commit 997204a

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

src/inspector_agent.cc

+6-5
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,8 @@ class JsBindingsSessionDelegate : public InspectorSessionDelegate {
219219
Local<Value> argument = v8string.ToLocalChecked().As<Value>();
220220
Local<Function> callback = callback_.Get(isolate);
221221
Local<Object> receiver = receiver_.Get(isolate);
222-
static_cast<void>(callback->Call(env_->context(), receiver, 1, &argument));
222+
callback->Call(env_->context(), receiver, 1, &argument)
223+
.FromMaybe(Local<Value>());
223224
}
224225

225226
void Disconnect() {
@@ -353,10 +354,10 @@ void InspectorConsoleCall(const v8::FunctionCallbackInfo<Value>& info) {
353354

354355
Local<Value> node_method = info[1];
355356
CHECK(node_method->IsFunction());
356-
static_cast<void>(node_method.As<Function>()->Call(context,
357-
info.Holder(),
358-
call_args.size(),
359-
call_args.data()));
357+
node_method.As<Function>()->Call(context,
358+
info.Holder(),
359+
call_args.size(),
360+
call_args.data()).FromMaybe(Local<Value>());
360361
}
361362

362363
void CallAndPauseOnStart(

src/node_url.cc

+3-2
Original file line numberDiff line numberDiff line change
@@ -1943,15 +1943,16 @@ static void Parse(Environment* env,
19431943
null, // fragment defaults to null
19441944
};
19451945
SetArgs(env, argv, &url);
1946-
(void)cb->Call(context, recv, arraysize(argv), argv);
1946+
cb->Call(context, recv, arraysize(argv), argv).FromMaybe(Local<Value>());
19471947
} else if (error_cb->IsFunction()) {
19481948
Local<Value> argv[2] = { undef, undef };
19491949
argv[ERR_ARG_FLAGS] = Integer::NewFromUnsigned(isolate, url.flags);
19501950
argv[ERR_ARG_INPUT] =
19511951
String::NewFromUtf8(env->isolate(),
19521952
input,
19531953
v8::NewStringType::kNormal).ToLocalChecked();
1954-
(void)error_cb.As<Function>()->Call(context, recv, arraysize(argv), argv);
1954+
error_cb.As<Function>()->Call(context, recv, arraysize(argv), argv)
1955+
.FromMaybe(Local<Value>());
19551956
}
19561957
}
19571958

0 commit comments

Comments
 (0)