Skip to content

Commit 9ad0e2c

Browse files
committed
deps: V8: cherry-pick 89b3702c92b0
Original commit message: Reland^2 "[iterator-helpers] Unship due to incompat" This is a reland of commit bab67985346dbc0d566391ad561537b4554455b4 Change since reland: A second breakage reported in chromium:1480783 Original change's description: > Reland "[iterator-helpers] Unship due to incompat" > > This is a reland of commit 1a22cf9896d682a9dfca589f92ed97c7f875b8a2 > > Change since revert: I mistakenly thought part of the finch > kill-switch playbook is to keep it enabled on ToT. It's actually > the opposite. > > Original change's description: > > [iterator-helpers] Unship due to incompat > > > > Bug: chromium:1474613, v8:13558 > > Change-Id: Iccba26e5cd5dc1787172c78b6e4f6889ef67fcea > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4834350 > > Reviewed-by: Adam Klein <[email protected]> > > Commit-Queue: Shu-yu Guo <[email protected]> > > Cr-Commit-Position: refs/heads/main@{#89741} > > Bug: chromium:1474613, v8:13558 > Change-Id: Idc421a114303f036622bff681c9fa252c9110b9d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4843761 > Commit-Queue: Rezvan Mahdavi Hezaveh <[email protected]> > Auto-Submit: Shu-yu Guo <[email protected]> > Commit-Queue: Shu-yu Guo <[email protected]> > Reviewed-by: Rezvan Mahdavi Hezaveh <[email protected]> > Cr-Commit-Position: refs/heads/main@{#89800} Bug: chromium:1474613, v8:13558 Change-Id: Ia933c874508f1ec10ea4718c6378858cd5bec8f9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4854732 Reviewed-by: Rezvan Mahdavi Hezaveh <[email protected]> Auto-Submit: Shu-yu Guo <[email protected]> Commit-Queue: Rezvan Mahdavi Hezaveh <[email protected]> Cr-Commit-Position: refs/heads/main@{#89905} Refs: v8/v8@89b3702 PR-URL: #49639 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
1 parent dfc9c86 commit 9ad0e2c

File tree

4 files changed

+7
-4
lines changed

4 files changed

+7
-4
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.10',
39+
'v8_embedder_string': '-node.11',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/src/flags/flag-definitions.h

+3-3
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,8 @@ DEFINE_BOOL(js_shipping, true, "enable all shipped JavaScript features")
278278

279279
// Features that are complete (but still behind the --harmony flag).
280280
#define HARMONY_STAGED_BASE(V) \
281-
V(harmony_set_methods, "harmony Set Methods")
281+
V(harmony_set_methods, "harmony Set Methods") \
282+
V(harmony_iterator_helpers, "JavaScript iterator helpers")
282283

283284
#define JAVASCRIPT_STAGED_FEATURES_BASE(V) \
284285
V(js_promise_withresolvers, "Promise.withResolvers")
@@ -303,8 +304,7 @@ DEFINE_WEAK_IMPLICATION(harmony_rab_gsab_transfer, harmony_rab_gsab)
303304
V(harmony_regexp_unicode_sets, "harmony RegExp Unicode Sets") \
304305
V(harmony_json_parse_with_source, "harmony json parse with source") \
305306
V(harmony_rab_gsab_transfer, "harmony ArrayBuffer.transfer") \
306-
V(harmony_array_grouping, "harmony array grouping") \
307-
V(harmony_iterator_helpers, "JavaScript iterator helpers")
307+
V(harmony_array_grouping, "harmony array grouping")
308308

309309
#define JAVASCRIPT_SHIPPING_FEATURES_BASE(V)
310310

deps/v8/test/mjsunit/es6/iterator-prototype.js

+2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5+
// Flags: --harmony-iterator-helpers
6+
57
var arrayIteratorPrototype = [].entries().__proto__;
68
var iteratorPrototype = arrayIteratorPrototype.__proto__;
79

deps/v8/test/mozilla/mozilla.status

+1
Original file line numberDiff line numberDiff line change
@@ -546,6 +546,7 @@
546546

547547
# Uses Mozilla-specific QName, XML, XMLList and Iterator.
548548
'js1_5/Regress/regress-407323': [FAIL_OK],
549+
'js1_5/Regress/regress-407957': [FAIL_OK],
549550

550551

551552
# Relies on JavaScript 1.2 / 1.3 deprecated features.

0 commit comments

Comments
 (0)