Skip to content

Commit 9b02442

Browse files
committed
Revert "src: fix stuck debugger process"
This reverts commit ff877e9. Reverted for breaking `node --debug-brk -e 0`. It should immediately quit but instead it hangs now. PR-URL: #3585 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 57bce60 commit 9b02442

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

src/node.cc

+2-4
Original file line numberDiff line numberDiff line change
@@ -3747,6 +3747,7 @@ void Init(int* argc,
37473747
uv_async_init(uv_default_loop(),
37483748
&dispatch_debug_messages_async,
37493749
DispatchDebugMessagesAsyncCallback);
3750+
uv_unref(reinterpret_cast<uv_handle_t*>(&dispatch_debug_messages_async));
37503751

37513752
#if defined(NODE_V8_OPTIONS)
37523753
// Should come before the call to V8::SetFlagsFromCommandLine()
@@ -4054,11 +4055,8 @@ static void StartNodeInstance(void* arg) {
40544055
env->set_trace_sync_io(trace_sync_io);
40554056

40564057
// Enable debugger
4057-
if (instance_data->use_debug_agent()) {
4058+
if (instance_data->use_debug_agent())
40584059
EnableDebug(env);
4059-
} else {
4060-
uv_unref(reinterpret_cast<uv_handle_t*>(&dispatch_debug_messages_async));
4061-
}
40624060

40634061
{
40644062
SealHandleScope seal(isolate);

0 commit comments

Comments
 (0)