Skip to content

Commit 9b3c115

Browse files
committed
deps: V8: cherry-pick 3b8c624
Original commit message: GCC: explicitely instantiate JSObject::ApplyAttributesToDictionary for NumberDictionary elements.cc invokes ApplyAttributesToDictionary using NumberDictionary as its template parameter. But the declaration of the template method is in js-object.cc, so nobody can actually compile the version for number dictionary. This is fixed requesting explicit instantiation for NumberDictionary. This was breaking GCC build. Bug: chromium:819294 Change-Id: I685ddc5b97e129d1a534dbdb04025c0932bc5ecd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1649565 Reviewed-by: Toon Verwaest <[email protected]> Commit-Queue: José Dapena Paz <[email protected]> Cr-Commit-Position: refs/heads/master@{#62097} Refs: v8/v8@3b8c624 Backport-PR-URL: #28955 PR-URL: #28016 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
1 parent 533b2d4 commit 9b3c115

File tree

3 files changed

+6
-1
lines changed

3 files changed

+6
-1
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
# Reset this number to 0 on major V8 upgrades.
4040
# Increment by one for each non-official patch applied to deps/v8.
41-
'v8_embedder_string': '-node.10',
41+
'v8_embedder_string': '-node.11',
4242

4343
##### V8 defaults for Node.js #####
4444

deps/v8/AUTHORS

+1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ NVIDIA Corporation <*@nvidia.com>
1515
BlackBerry Limited <*@blackberry.com>
1616
Opera Software ASA <*@opera.com>
1717
Intel Corporation <*@intel.com>
18+
LG Electronics, Inc. <*@lge.com>
1819
Microsoft <*@microsoft.com>
1920
MIPS Technologies, Inc. <*@mips.com>
2021
Imagination Technologies, LLC <*@imgtec.com>

deps/v8/src/objects/js-objects.cc

+4
Original file line numberDiff line numberDiff line change
@@ -3752,6 +3752,10 @@ void JSObject::ApplyAttributesToDictionary(
37523752
}
37533753
}
37543754

3755+
template void JSObject::ApplyAttributesToDictionary(
3756+
Isolate* isolate, ReadOnlyRoots roots, Handle<NumberDictionary> dictionary,
3757+
const PropertyAttributes attributes);
3758+
37553759
template <PropertyAttributes attrs>
37563760
Maybe<bool> JSObject::PreventExtensionsWithTransition(
37573761
Handle<JSObject> object, ShouldThrow should_throw) {

0 commit comments

Comments
 (0)