Skip to content

Commit 9bc02ff

Browse files
gibfahnMylesBorins
authored andcommitted
doc: note that linting is required in releases.md
Refs: #18769 PR-URL: #18776 Refs: #18769 Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 0a27ec4 commit 9bc02ff

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

doc/releases.md

+3
Original file line numberDiff line numberDiff line change
@@ -269,6 +269,9 @@ Merge your release proposal branch into the stable branch that you are releasing
269269

270270
Cherry-pick the release commit to `master`. After cherry-picking, edit `src/node_version.h` to ensure the version macros contain whatever values were previously on `master`. `NODE_VERSION_IS_RELEASE` should be `0`.
271271

272+
Run `make lint-md-build; make lint` before pushing to `master`, to make sure the
273+
Changelog formatting passes the lint rules on `master`.
274+
272275
### 12. Promote and Sign the Release Builds
273276

274277
**It is important that the same individual who signed the release tag be the one to promote the builds as the SHASUMS256.txt file needs to be signed with the same GPG key!**

0 commit comments

Comments
 (0)