Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 9bde9b2

Browse files
isheludkoaduh95
authored andcommittedJul 16, 2024
src: fix implementation of PropertySetterCallback
V8 does not allow returning arbitrary values from the interceptor setter callbacks, only a boolean return value is allowed. Since default return value is `true`, it's not even necessary to set the return value on a successful path. Refs: https://crbug.com/348660658 PR-URL: #53576 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
1 parent c68d873 commit 9bde9b2

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed
 

‎src/node_contextify.cc

-1
Original file line numberDiff line numberDiff line change
@@ -614,7 +614,6 @@ Intercepted ContextifyContext::PropertySetterCallback(
614614
// property
615615
if (desc_obj->HasOwnProperty(context, env->get_string()).FromMaybe(false) ||
616616
desc_obj->HasOwnProperty(context, env->set_string()).FromMaybe(false)) {
617-
args.GetReturnValue().Set(value);
618617
return Intercepted::kYes;
619618
}
620619
}

0 commit comments

Comments
 (0)
Please sign in to comment.