Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 9c66730

Browse files
committedJul 29, 2022
deps: silence V8's warning on CompileFunction
We are not ready to migrate yet. Refs: nodejs/node-v8#214 PR-URL: #40907 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
1 parent 358aa24 commit 9c66730

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed
 

‎common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.3',
39+
'v8_embedder_string': '-node.4',
4040

4141
##### V8 defaults for Node.js #####
4242

‎deps/v8/include/v8-script.h

-1
Original file line numberDiff line numberDiff line change
@@ -698,7 +698,6 @@ class V8_EXPORT ScriptCompiler {
698698
* It is possible to specify multiple context extensions (obj in the above
699699
* example).
700700
*/
701-
V8_DEPRECATED("Use CompileFunction")
702701
static V8_WARN_UNUSED_RESULT MaybeLocal<Function> CompileFunctionInContext(
703702
Local<Context> context, Source* source, size_t arguments_count,
704703
Local<String> arguments[], size_t context_extension_count,

0 commit comments

Comments
 (0)
Please sign in to comment.