Skip to content

Commit 9cfb418

Browse files
richardlaujasnell
authored andcommitted
build: package release changelog for releases
Package the changelog for the release line as `CHANGELOG.md` when building a release binary tarball. PR-URL: #38033 Fixes: #38025 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 098a4d6 commit 9cfb418

File tree

1 file changed

+14
-0
lines changed

1 file changed

+14
-0
lines changed

Diff for: Makefile

+14
Original file line numberDiff line numberDiff line change
@@ -773,6 +773,7 @@ docclean:
773773

774774
RAWVER=$(shell $(PYTHON) tools/getnodeversion.py)
775775
VERSION=v$(RAWVER)
776+
CHANGELOG=doc/changelogs/CHANGELOG_V$(firstword $(subst ., ,$(RAWVER))).md
776777

777778
# For nightly builds, you must set DISTTYPE to "nightly", "next-nightly" or
778779
# "custom". For the nightly and next-nightly case, you need to set DATESTRING
@@ -960,6 +961,15 @@ release-only: check-xz
960961
echo "" >&2 ; \
961962
exit 1 ; \
962963
fi
964+
@if [ "$(RELEASE)" = "0" -o -f "$(CHANGELOG)" ]; then \
965+
exit 0; \
966+
else \
967+
echo "" >&2 ; \
968+
echo "#NODE_VERSION_IS_RELEASE is set to $(RELEASE) but " >&2 ; \
969+
echo "$(CHANGELOG) does not exist." >&2 ; \
970+
echo "" >&2 ; \
971+
exit 1 ; \
972+
fi
963973

964974
$(PKG): release-only
965975
$(RM) -r $(MACOSOUTDIR)
@@ -1127,7 +1137,11 @@ $(BINARYTAR): release-only
11271137
$(MAKE) install DESTDIR=$(BINARYNAME) V=$(V) PORTABLE=1
11281138
cp README.md $(BINARYNAME)
11291139
cp LICENSE $(BINARYNAME)
1140+
ifeq ("$(wildcard $(CHANGELOG))","")
11301141
cp CHANGELOG.md $(BINARYNAME)
1142+
else
1143+
cp $(CHANGELOG) $(BINARYNAME)/CHANGELOG.md
1144+
endif
11311145
ifeq ($(OSTYPE),darwin)
11321146
SIGN="$(CODESIGN_CERT)" PKGDIR="$(BINARYNAME)" sh tools/osx-codesign.sh
11331147
endif

0 commit comments

Comments
 (0)