Skip to content

Commit 9d9bcd7

Browse files
TrottMylesBorins
authored andcommitted
meta: clarify process for breaking changes
Fixes: #7848 PR-URL: #7955 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Julien Gilli <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
1 parent 009df78 commit 9d9bcd7

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

COLLABORATOR_GUIDE.md

+10-2
Original file line numberDiff line numberDiff line change
@@ -60,12 +60,20 @@ and work schedules. Trivial changes (e.g. those which fix minor bugs
6060
or improve performance without affecting API or causing other
6161
wide-reaching impact) may be landed after a shorter delay.
6262

63-
Where there is no disagreement amongst Collaborators, a pull request
64-
may be landed given appropriate review. Where there is discussion
63+
For non-breaking changes, if there is no disagreement amongst Collaborators, a
64+
pull request may be landed given appropriate review. Where there is discussion
6565
amongst Collaborators, consensus should be sought if possible. The
6666
lack of consensus may indicate the need to elevate discussion to the
6767
CTC for resolution (see below).
6868

69+
Breaking changes (that is, pull requests that require an increase in the
70+
major version number, known as `semver-major` changes) must be elevated for
71+
review by the CTC. This does not necessarily mean that the PR must be put onto
72+
the CTC meeting agenda. If multiple CTC members approve (`LGTM`) the PR and no
73+
Collaborators oppose the PR, it can be landed. Where there is disagreement among
74+
CTC members or objections from one or more Collaborators, `semver-major` pull
75+
requests should be put on the CTC meeting agenda.
76+
6977
All bugfixes require a test case which demonstrates the defect. The
7078
test should *fail* before the change, and *pass* after the change.
7179

0 commit comments

Comments
 (0)