Skip to content

Commit 9de08f7

Browse files
BridgeARaddaleax
authored andcommitted
lib: update TODO comments
This removes one TODO comment and adds another that indicates that readline is currently not able to trigger specific escape sequences. Signed-off-by: Ruben Bridgewater <[email protected]> PR-URL: #33361 Reviewed-By: Anto Aravinth <[email protected]>
1 parent da7be69 commit 9de08f7

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

lib/readline.js

+5-1
Original file line numberDiff line numberDiff line change
@@ -855,6 +855,8 @@ Interface.prototype._ttyWrite = function(s, key) {
855855
if (key.ctrl && key.shift) {
856856
/* Control and shift pressed */
857857
switch (key.name) {
858+
// TODO(BridgeAR): The transmitted escape sequence is `\b` and that is
859+
// identical to <ctrl>-h. It should have a unique escape sequence.
858860
case 'backspace':
859861
this._deleteLineLeft();
860862
break;
@@ -952,8 +954,10 @@ Interface.prototype._ttyWrite = function(s, key) {
952954
}
953955
break;
954956

955-
// TODO(BridgeAR): This seems broken?
956957
case 'w': // Delete backwards to a word boundary
958+
// TODO(BridgeAR): The transmitted escape sequence is `\b` and that is
959+
// identical to <ctrl>-h. It should have a unique escape sequence.
960+
// Falls through
957961
case 'backspace':
958962
this._deleteWordLeft();
959963
break;

test/parallel/test-assert-deep.js

-2
Original file line numberDiff line numberDiff line change
@@ -957,8 +957,6 @@ assertDeepAndStrictEqual(obj1, obj2);
957957

958958
// Check proxies.
959959
{
960-
// TODO(BridgeAR): Check if it would not be better to detect proxies instead
961-
// of just using the proxy value.
962960
const arrProxy = new Proxy([1, 2], {});
963961
assert.deepStrictEqual(arrProxy, [1, 2]);
964962
const tmp = util.inspect.defaultOptions;

0 commit comments

Comments
 (0)