Skip to content

Commit 9e1dcdc

Browse files
committed
src: remove NodeCategorySet destructor
This currently crashes during environment cleanup because the object would be torn down while there are enabled categories. I’m not sure about the exact semantics here, but since the object cannot be garbage collected at this point anyway because it’s `Persistent` handle is strong, removing the destructor at least doesn’t make anything worse than it is right now (i.e. the destructor would never have been called before anyway). PR-URL: #19377 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 97d939a commit 9e1dcdc

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

src/node_trace_events.cc

-5
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,6 @@ using v8::Value;
2121

2222
class NodeCategorySet : public BaseObject {
2323
public:
24-
~NodeCategorySet() override {
25-
// Verify that the thing was properly disabled before gc
26-
CHECK_NE(enabled_, true);
27-
}
28-
2924
static void New(const FunctionCallbackInfo<Value>& args);
3025
static void Enable(const FunctionCallbackInfo<Value>& args);
3126
static void Disable(const FunctionCallbackInfo<Value>& args);

0 commit comments

Comments
 (0)