Skip to content

Commit 9edd6d8

Browse files
jeisingerjasnell
authored andcommitted
deps: backport 2cd2f5feff3 from upstream v8
Original commit message: Remove experimental fast accessor builder API As the code isn't used, but would have to be ported from hand-written assembly to CodeStubAssembler anyways, I propose to remove it and restore it if we decide that we actually need it. [email protected] BUG= Change-Id: Iffd7fc6ec534b1dd7a9144da900424355c8a7a02 Reviewed-on: https://chromium-review.googlesource.com/453461 Commit-Queue: Jochen Eisinger <[email protected]> Reviewed-by: Daniel Vogelheim <[email protected]> Reviewed-by: Benedikt Meurer <[email protected]> Cr-Commit-Position: refs/heads/master@{#43763} Ref: v8/v8@2cd2f5feff3 PR-URL: #12875 Reviewed-By: James M Snell <[email protected]>
1 parent 19c0c07 commit 9edd6d8

37 files changed

+14
-2336
lines changed

deps/v8/BUILD.gn

-5
Original file line numberDiff line numberDiff line change
@@ -887,7 +887,6 @@ v8_source_set("v8_base") {
887887

888888
### gcmole(all) ###
889889
"include/v8-debug.h",
890-
"include/v8-experimental.h",
891890
"include/v8-platform.h",
892891
"include/v8-profiler.h",
893892
"include/v8-testing.h",
@@ -905,8 +904,6 @@ v8_source_set("v8_base") {
905904
"src/api-arguments-inl.h",
906905
"src/api-arguments.cc",
907906
"src/api-arguments.h",
908-
"src/api-experimental.cc",
909-
"src/api-experimental.h",
910907
"src/api-natives.cc",
911908
"src/api-natives.h",
912909
"src/api.cc",
@@ -1386,8 +1383,6 @@ v8_source_set("v8_base") {
13861383
"src/external-reference-table.h",
13871384
"src/factory.cc",
13881385
"src/factory.h",
1389-
"src/fast-accessor-assembler.cc",
1390-
"src/fast-accessor-assembler.h",
13911386
"src/fast-dtoa.cc",
13921387
"src/fast-dtoa.h",
13931388
"src/feedback-vector-inl.h",

deps/v8/include/v8-experimental.h

-58
This file was deleted.

deps/v8/include/v8.h

+2-17
Original file line numberDiff line numberDiff line change
@@ -137,10 +137,6 @@ class CallHandlerHelper;
137137
class EscapableHandleScope;
138138
template<typename T> class ReturnValue;
139139

140-
namespace experimental {
141-
class FastAccessorBuilder;
142-
} // namespace experimental
143-
144140
namespace internal {
145141
class Arguments;
146142
class Heap;
@@ -5098,16 +5094,6 @@ class V8_EXPORT FunctionTemplate : public Template {
50985094
static MaybeLocal<FunctionTemplate> FromSnapshot(Isolate* isolate,
50995095
size_t index);
51005096

5101-
/**
5102-
* Creates a function template with a fast handler. If a fast handler is set,
5103-
* the callback cannot be null.
5104-
*/
5105-
static Local<FunctionTemplate> NewWithFastHandler(
5106-
Isolate* isolate, FunctionCallback callback,
5107-
experimental::FastAccessorBuilder* fast_handler = nullptr,
5108-
Local<Value> data = Local<Value>(),
5109-
Local<Signature> signature = Local<Signature>(), int length = 0);
5110-
51115097
/**
51125098
* Creates a function template backed/cached by a private property.
51135099
*/
@@ -5135,9 +5121,8 @@ class V8_EXPORT FunctionTemplate : public Template {
51355121
* callback is called whenever the function created from this
51365122
* FunctionTemplate is called.
51375123
*/
5138-
void SetCallHandler(
5139-
FunctionCallback callback, Local<Value> data = Local<Value>(),
5140-
experimental::FastAccessorBuilder* fast_handler = nullptr);
5124+
void SetCallHandler(FunctionCallback callback,
5125+
Local<Value> data = Local<Value>());
51415126

51425127
/** Set the predefined length property for the FunctionTemplate. */
51435128
void SetLength(int length);

deps/v8/src/api-experimental.cc

-139
This file was deleted.

deps/v8/src/api-experimental.h

-28
This file was deleted.

0 commit comments

Comments
 (0)