Skip to content

Commit 9f84d3e

Browse files
gengjiawennodejs-github-bot
authored andcommittedNov 27, 2022
deps: V8: fix v8-cppgc.h for MSVC
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: #42375 PR-URL: #42657 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]> PR-URL: #45579 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent f2318cd commit 9f84d3e

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed
 

‎common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.1',
39+
'v8_embedder_string': '-node.2',
4040

4141
##### V8 defaults for Node.js #####
4242

‎deps/v8/include/v8-cppgc.h

+3
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,9 @@ struct WrapperDescriptor final {
7777
};
7878

7979
struct V8_EXPORT CppHeapCreateParams {
80+
CppHeapCreateParams(const CppHeapCreateParams&) = delete;
81+
CppHeapCreateParams& operator=(const CppHeapCreateParams&) = delete;
82+
8083
std::vector<std::unique_ptr<cppgc::CustomSpaceBase>> custom_spaces;
8184
WrapperDescriptor wrapper_descriptor;
8285
/**

0 commit comments

Comments
 (0)
Please sign in to comment.