Skip to content

Commit 9ffdee8

Browse files
TrottMylesBorins
authored andcommitted
benchmark: use unique filenames in fs benchmarks
Use a unique file name for each benchmark. Running benchmarks simultaneously may be a bit of an unusual use case, but there are use cases, such as stress testing `test/parallel/test-benchmark-fs.js`. PR-URL: #16776 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent b931169 commit 9ffdee8

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

benchmark/fs/read-stream-throughput.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33

44
const path = require('path');
55
const common = require('../common.js');
6-
const filename = path.resolve(__dirname, '.removeme-benchmark-garbage');
6+
const filename = path.resolve(__dirname,
7+
`.removeme-benchmark-garbage-${process.pid}`);
78
const fs = require('fs');
89
const assert = require('assert');
910

benchmark/fs/readfile.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@
55

66
const path = require('path');
77
const common = require('../common.js');
8-
const filename = path.resolve(__dirname, '.removeme-benchmark-garbage');
8+
const filename = path.resolve(__dirname,
9+
`.removeme-benchmark-garbage-${process.pid}`);
910
const fs = require('fs');
1011

1112
const bench = common.createBenchmark(main, {

benchmark/fs/write-stream-throughput.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33

44
const path = require('path');
55
const common = require('../common.js');
6-
const filename = path.resolve(__dirname, '.removeme-benchmark-garbage');
6+
const filename = path.resolve(__dirname,
7+
`.removeme-benchmark-garbage-${process.pid}`);
78
const fs = require('fs');
89

910
const bench = common.createBenchmark(main, {

0 commit comments

Comments
 (0)