Skip to content

Commit a03aaba

Browse files
TrottRafaelGSS
authored andcommitted
doc: update collaborator guide to reflect TSC changes
Ref: nodejs/TSC#1350 PR-URL: #47126 Refs: nodejs/TSC#1350 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
1 parent d78bef8 commit a03aaba

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

doc/contributing/collaborator-guide.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -340,8 +340,8 @@ For undocumented APIs that are public, open a pull request documenting the API.
340340

341341
### Breaking changes
342342

343-
At least two TSC members must approve backward-incompatible changes to the
344-
`main` branch.
343+
At least two TSC voting members must approve backward-incompatible changes to
344+
the `main` branch.
345345

346346
Examples of breaking changes include:
347347

@@ -411,7 +411,7 @@ possible to avoid confusion and typosquatting attacks.
411411
For pull requests introducing new core modules:
412412

413413
* Allow at least one week for review.
414-
* Land only after sign-off from at least two TSC members.
414+
* Land only after sign-off from at least two TSC voting members.
415415
* Land with a [Stability Index][] of Experimental. The module must remain
416416
Experimental until a semver-major release.
417417

@@ -742,7 +742,7 @@ git push upstream main
742742

743743
### I made a mistake
744744

745-
* Ping a TSC member.
745+
* Ping a TSC voting member.
746746
* With `git`, there's a way to override remote trees by force pushing
747747
(`git push -f`). This is generally forbidden as it creates conflicts in other
748748
people's forks. It is permissible for simpler slip-ups such as typos in commit

0 commit comments

Comments
 (0)