Skip to content

Commit a052c03

Browse files
committed
deps: V8: cherry-pick ca2a787a0b49
Original commit message: Fix build with Windows 10 20348 SDK Bug: chromium:1292528 Change-Id: If4da2ec92afb7b4fe9942778eca385344b9b6409 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3563539 Auto-Submit: Yuly Novikov <[email protected]> Reviewed-by: Michael Lippautz <[email protected]> Commit-Queue: Michael Lippautz <[email protected]> Cr-Commit-Position: refs/heads/main@{#79709} Refs: v8/v8@ca2a787 PR-URL: #42657 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
1 parent 01cea9a commit a052c03

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.9',
39+
'v8_embedder_string': '-node.10',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/src/base/cpu.cc

+4-2
Original file line numberDiff line numberDiff line change
@@ -764,9 +764,11 @@ CPU::CPU()
764764
// user-space.
765765
has_non_stop_time_stamp_counter_ = true;
766766

767-
// Defined in winnt.h, but in a newer version of the Windows SDK than the one
768-
// that V8 requires, so we must copy the value here.
767+
// Defined in winnt.h, but only in 10.0.20348.0 version of the Windows SDK.
768+
// Copy the value here to support older versions as well.
769+
#if !defined(PF_ARM_V83_JSCVT_INSTRUCTIONS_AVAILABLE)
769770
constexpr int PF_ARM_V83_JSCVT_INSTRUCTIONS_AVAILABLE = 44;
771+
#endif
770772

771773
has_jscvt_ =
772774
IsProcessorFeaturePresent(PF_ARM_V83_JSCVT_INSTRUCTIONS_AVAILABLE);

0 commit comments

Comments
 (0)