Skip to content

Commit a086604

Browse files
hectorcoronadotargos
authored andcommitted
test: remove 3rd arg from to assert.strictEqual()
prevents AssertionError from reporting string literal, instead displays values of first 2 args passed to assert.strictEqual() PR-URL: #21828 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 6487d8d commit a086604

File tree

1 file changed

+20
-10
lines changed

1 file changed

+20
-10
lines changed

test/parallel/test-stream-transform-final-sync.js

+20-10
Original file line numberDiff line numberDiff line change
@@ -59,42 +59,52 @@ The order things are called
5959
const t = new stream.Transform({
6060
objectMode: true,
6161
transform: common.mustCall(function(chunk, _, next) {
62-
assert.strictEqual(++state, chunk, 'transformCallback part 1');
62+
// transformCallback part 1
63+
assert.strictEqual(++state, chunk);
6364
this.push(state);
64-
assert.strictEqual(++state, chunk + 2, 'transformCallback part 2');
65+
// transformCallback part 2
66+
assert.strictEqual(++state, chunk + 2);
6567
process.nextTick(next);
6668
}, 3),
6769
final: common.mustCall(function(done) {
6870
state++;
69-
assert.strictEqual(state, 10, 'finalCallback part 1');
71+
// finalCallback part 1
72+
assert.strictEqual(state, 10);
7073
state++;
71-
assert.strictEqual(state, 11, 'finalCallback part 2');
74+
// finalCallback part 2
75+
assert.strictEqual(state, 11);
7276
done();
7377
}, 1),
7478
flush: common.mustCall(function(done) {
7579
state++;
76-
assert.strictEqual(state, 12, 'flushCallback part 1');
80+
// fluchCallback part 1
81+
assert.strictEqual(state, 12);
7782
process.nextTick(function() {
7883
state++;
79-
assert.strictEqual(state, 15, 'flushCallback part 2');
84+
// fluchCallback part 2
85+
assert.strictEqual(state, 15);
8086
done();
8187
});
8288
}, 1)
8389
});
8490
t.on('finish', common.mustCall(function() {
8591
state++;
86-
assert.strictEqual(state, 13, 'finishListener');
92+
// finishListener
93+
assert.strictEqual(state, 13);
8794
}, 1));
8895
t.on('end', common.mustCall(function() {
8996
state++;
90-
assert.strictEqual(state, 16, 'end event');
97+
// endEvent
98+
assert.strictEqual(state, 16);
9199
}, 1));
92100
t.on('data', common.mustCall(function(d) {
93-
assert.strictEqual(++state, d + 1, 'dataListener');
101+
// dataListener
102+
assert.strictEqual(++state, d + 1);
94103
}, 3));
95104
t.write(1);
96105
t.write(4);
97106
t.end(7, common.mustCall(function() {
98107
state++;
99-
assert.strictEqual(state, 14, 'endMethodCallback');
108+
// endMethodCallback
109+
assert.strictEqual(state, 14);
100110
}, 1));

0 commit comments

Comments
 (0)