Skip to content

Commit a159bfa

Browse files
committed
[suggestion] flipped if and skip jslint
1 parent c9ef989 commit a159bfa

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

vcbuild.bat

+6-5
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ if /i "%1"=="download-all" set download_arg="--download=all"&goto arg-ok
107107
if /i "%1"=="ignore-flaky" set test_args=%test_args% --flaky-tests=dontcare&goto arg-ok
108108
if /i "%1"=="enable-vtune" set enable_vtune_arg=1&goto arg-ok
109109
if /i "%1"=="dll" set dll=1&goto arg-ok
110-
if /i "%1"=="static" set enable_static=1&goto arg-ok
110+
if /i "%1"=="static" set enable_static=1&goto arg-ok
111111
if /i "%1"=="no-NODE-OPTIONS" set no_NODE_OPTIONS=1&goto arg-ok
112112
if /i "%1"=="debug-http2" set debug_http2=1&goto arg-ok
113113
if /i "%1"=="debug-nghttp2" set debug_nghttp2=1&goto arg-ok
@@ -445,10 +445,10 @@ if "%config%"=="Debug" set test_args=--mode=debug %test_args%
445445
if "%config%"=="Release" set test_args=--mode=release %test_args%
446446
echo running 'cctest %cctest_args%'
447447
"%config%\cctest" %cctest_args%
448-
if not defined enable_static (
449-
call :run-python tools\test.py %test_args%
450-
goto test-v8
451-
)
448+
REM when building a static library there's no binary to run tests
449+
if defined enable_static goto test-v8
450+
call :run-python tools\test.py %test_args%
451+
452452
:test-v8
453453
if not defined custom_v8_test goto cpplint
454454
call tools/test-v8.bat
@@ -495,6 +495,7 @@ set "localcppfilelist=%localcppfilelist% %1"
495495
goto exit
496496

497497
:jslint
498+
if defined enable_static goto exit
498499
if defined jslint_ci goto jslint-ci
499500
if not defined jslint goto exit
500501
if not exist tools\eslint\bin\eslint.js goto no-lint

0 commit comments

Comments
 (0)