test: dynamic port in cluster worker disconnect

Remove common.PORT from test-cluster-worker-disconnect-on-error
possibility that a dynamic port used in another test will collide
with common.PORT.

PR-URL: #12457
Ref: #12376
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>

Author: Sebastian Plesciuc

test/parallel/test-cluster-worker-disconnect-on-error.js

@@ -2,19 +2,32 @@
 const common = require('../common');
 const http = require('http');
 const cluster = require('cluster');
+const assert = require('assert');
 
 cluster.schedulingPolicy = cluster.SCHED_NONE;
 
 const server = http.createServer();
 if (cluster.isMaster) {
-  server.listen(common.PORT);
-  const worker = cluster.fork();
+  let worker;
+
+  server.listen(0, common.mustCall((error) => {
+    assert.ifError(error);
+    assert(worker);
+
+    worker.send({port: server.address().port});
+  }));
+
+  worker = cluster.fork();
   worker.on('exit', common.mustCall(() => {
     server.close();
   }));
 } else {
-  server.listen(common.PORT);
-  server.on('error', common.mustCall((e) => {
-    cluster.worker.disconnect();
+  process.on('message', common.mustCall((msg) => {
+    assert(msg.port);
+
+    server.listen(msg.port);
+    server.on('error', common.mustCall((e) => {
+      cluster.worker.disconnect();
+    }));
   }));
 }