Skip to content

Commit a29d6d3

Browse files
indutnyMyles Borins
authored and
Myles Borins
committed
configure: v8_use_snapshot should be true
`v8_use_snapshot` should be either `true` or `false`, not 1 or 0. PR-URL: #3962 Reviewed-By: Ali Ijaz Sheikh <[email protected]>
1 parent e73d697 commit a29d6d3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

configure

+1-1
Original file line numberDiff line numberDiff line change
@@ -768,7 +768,7 @@ def configure_v8(o):
768768
o['variables']['v8_no_strict_aliasing'] = 1 # Work around compiler bugs.
769769
o['variables']['v8_optimized_debug'] = 0 # Compile with -O0 in debug builds.
770770
o['variables']['v8_random_seed'] = 0 # Use a random seed for hash tables.
771-
o['variables']['v8_use_snapshot'] = 0 if options.without_snapshot else 1
771+
o['variables']['v8_use_snapshot'] = 'false' if options.without_snapshot else 'true'
772772

773773
def configure_openssl(o):
774774
o['variables']['node_use_openssl'] = b(not options.without_ssl)

0 commit comments

Comments
 (0)