File tree 1 file changed +11
-0
lines changed
doc/contributing/maintaining
1 file changed +11
-0
lines changed Original file line number Diff line number Diff line change @@ -123,6 +123,17 @@ can be added by:
123
123
paste one of the existing entries and then update to match the
124
124
import name for the dependency and the #define generated.
125
125
126
+ * if the version of the dependency is reported in ` process.versions ` ,
127
+ update ` src/node_metadata.h ` and ` src/node_metadata.cc ` so that the
128
+ version is not reported when the dependency is externalized.
129
+ Not reporting the version is better than incorrectly reporting
130
+ the version of the dependency bundled with Node.js, instead of the
131
+ version for the externalized dependency. Use one of the existing
132
+ externalized dependencies, like Undici, as an example of how to
133
+ update these files correctly. Make sure to run the tests with the
134
+ dependency externalized, as the tests will also need to be updated
135
+ to handle this properly.
136
+
126
137
## Supporting non-externalized dependencies with JavaScript code
127
138
128
139
If the dependency consists of JavaScript in the
You can’t perform that action at this time.
0 commit comments