Skip to content

Commit a6b9299

Browse files
sam-githubtargos
authored andcommitted
src: rename --security-reverts to ...-revert
It was called --security-revert prior to 12.x, but changed in #22490. See: nodejs/nodejs.org#2412 (comment) PR-URL: #29153 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 7f11c72 commit a6b9299

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

src/node_options.cc

+6-1
Original file line numberDiff line numberDiff line change
@@ -645,7 +645,12 @@ PerProcessOptionsParser::PerProcessOptionsParser(
645645
&PerProcessOptions::debug_arraybuffer_allocations,
646646
kAllowedInEnvironment);
647647

648-
AddOption("--security-reverts", "", &PerProcessOptions::security_reverts);
648+
649+
// 12.x renamed this inadvertently, so alias it for consistency within the
650+
// release line, while using the original name for consistency with older
651+
// release lines.
652+
AddOption("--security-revert", "", &PerProcessOptions::security_reverts);
653+
AddAlias("--security-reverts", "--security-revert");
649654
AddOption("--completion-bash",
650655
"print source-able bash completion script",
651656
&PerProcessOptions::print_bash_completion);

test/parallel/test-security-revert-unknown.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ const { spawnSync } = require('child_process');
55
const os = require('os');
66

77
const { signal, status, output } =
8-
spawnSync(process.execPath, ['--security-reverts=not-a-cve']);
8+
spawnSync(process.execPath, ['--security-revert=not-a-cve']);
99
assert.strictEqual(signal, null);
1010
assert.strictEqual(status, 12);
1111
assert.strictEqual(

0 commit comments

Comments
 (0)