Skip to content

Commit a758f9b

Browse files
sam-githubtargos
authored andcommitted
src: remove node_options-inl.h from header files
Fix unnecessary inclusion of node_options-inl.h into env.h via inspector_agent.h, causing almost all of src/ to recompile on any change to the options parser. Its intended that *-inl.h header files are only included into the src files that call the inline methods. PR-URL: #27538 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
1 parent d648ecc commit a758f9b

File tree

3 files changed

+3
-1
lines changed

3 files changed

+3
-1
lines changed

src/inspector_agent.cc

+1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
#include "node/inspector/protocol/Protocol.h"
1010
#include "node_errors.h"
1111
#include "node_internals.h"
12+
#include "node_options-inl.h"
1213
#include "node_process.h"
1314
#include "node_url.h"
1415
#include "v8-inspector.h"

src/inspector_agent.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
#error("This header can only be used when inspector is enabled")
77
#endif
88

9-
#include "node_options-inl.h"
9+
#include "node_options.h"
1010
#include "v8.h"
1111

1212
#include <cstddef>

src/node_worker.cc

+1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
#include "debug_utils.h"
33
#include "node_errors.h"
44
#include "node_buffer.h"
5+
#include "node_options-inl.h"
56
#include "node_perf.h"
67
#include "util.h"
78
#include "async_wrap-inl.h"

0 commit comments

Comments
 (0)