Skip to content

Commit a814786

Browse files
addaleaxcjihrig
authored andcommitted
src: improve module loader readability
Various improvements on readability, performance and conformity to the Node core coding style in the ESM loader C++ code: - `isolate` for the `Isolate*`, `context` for the `Local<Context>` - Less reliance on `auto` where it’s unnecessary/increases cognitive overhead - Shorter paths to failure via `.ToLocal()` & co - Do not keep pending exceptions around e.g. for failed `JSON` parsing - Use `Maybe` types to get explicit error status forwarding - Remove an unnecessary handle scope - Add `nullptr` checks for unwrapped host objects - Remove unused code - Use `CamelCase` for function names - Use `const Foo&` instead of copying values whenever possible - Pass along the `Environment*` explicitly PR-URL: #16536 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
1 parent 7349d42 commit a814786

File tree

4 files changed

+227
-207
lines changed

4 files changed

+227
-207
lines changed

src/env.h

+1
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,7 @@ class ModuleWrap;
185185
V(kill_signal_string, "killSignal") \
186186
V(length_string, "length") \
187187
V(mac_string, "mac") \
188+
V(main_string, "main") \
188189
V(max_buffer_string, "maxBuffer") \
189190
V(message_string, "message") \
190191
V(minttl_string, "minttl") \

0 commit comments

Comments
 (0)