Skip to content

Commit a892e29

Browse files
committed
doc: clarify release process for new releasers
1 parent adef64c commit a892e29

File tree

1 file changed

+15
-1
lines changed

1 file changed

+15
-1
lines changed

doc/contributing/releases.md

+15-1
Original file line numberDiff line numberDiff line change
@@ -468,7 +468,19 @@ failed build if you start again!
468468
Jenkins collects the artifacts from the builds, allowing you to download and
469469
install the new build. Make sure that the build appears correct. Check the
470470
version numbers, and perform some basic checks to confirm that all is well with
471-
the build before moving forward.
471+
the build before moving forward. Use the following list as a baseline:
472+
473+
* `process.version` is as expected
474+
* `process.release` is as expected
475+
* `process.versions` is as expected (for example, `openssl` or `llhttp` version
476+
must be in the expected updated version)
477+
* npm version (check it matches what we expect)
478+
* Run the test suite against the built binaries (optional)
479+
```console
480+
./tools/test.py --shell ~/Downloads/node-v18.5.0-linux-x64/bin/node
481+
```
482+
<sup>There may be test issues if the branch used to test does not match the Node.js binary.</sup>
483+
472484

473485
### 11. Tag and sign the release commit
474486

@@ -510,6 +522,8 @@ include the release code name.
510522
The tag **must** be signed using the GPG key that's listed for you on the
511523
project README.
512524

525+
**Note**: Don't push the tag to remote at this point.
526+
513527
### 12. Set up for the next release
514528

515529
On release proposal branch, edit `src/node_version.h` again and:

0 commit comments

Comments
 (0)