Skip to content

Commit a8eac78

Browse files
committed
Revert "console: use consolePropAttributes for k-bind properties in constructor"
This reverts commit ed5e69d. PR-URL: #26943 Refs: #26850 (comment) Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
1 parent ed5e69d commit a8eac78

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

lib/internal/console/constructor.js

+8-6
Original file line numberDiff line numberDiff line change
@@ -181,13 +181,15 @@ Console.prototype[kBindProperties] = function(ignoreErrors, colorMode) {
181181
...consolePropAttributes,
182182
value: Boolean(ignoreErrors)
183183
},
184-
'_times': { ...consolePropAttributes, value: new Map() },
185-
// Corresponds to https://console.spec.whatwg.org/#count-map
186-
[kCounts]: { ...consolePropAttributes, value: new Map() },
187-
[kColorMode]: { ...consolePropAttributes, value: colorMode },
188-
[kIsConsole]: { ...consolePropAttributes, value: true },
189-
[kGroupIndent]: { ...consolePropAttributes, value: '' }
184+
'_times': { ...consolePropAttributes, value: new Map() }
190185
});
186+
187+
// TODO(joyeecheung): use consolePropAttributes for these
188+
// Corresponds to https://console.spec.whatwg.org/#count-map
189+
this[kCounts] = new Map();
190+
this[kColorMode] = colorMode;
191+
this[kIsConsole] = true;
192+
this[kGroupIndent] = '';
191193
};
192194

193195
// Make a function that can serve as the callback passed to `stream.write()`.

0 commit comments

Comments
 (0)