Skip to content

Commit aa481c4

Browse files
Shubhamurkadervagg
authored andcommitted
src: elevate repeated use of v8 namespaced type
PR-URL: #24427 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
1 parent de378c0 commit aa481c4

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

src/inspector_agent.cc

+7-6
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ using v8::Function;
3737
using v8::HandleScope;
3838
using v8::Isolate;
3939
using v8::Local;
40+
using v8::Message;
4041
using v8::Object;
4142
using v8::String;
4243
using v8::Value;
@@ -362,7 +363,7 @@ class SameThreadInspectorSession : public InspectorSession {
362363
};
363364

364365
void NotifyClusterWorkersDebugEnabled(Environment* env) {
365-
v8::Isolate* isolate = env->isolate();
366+
Isolate* isolate = env->isolate();
366367
HandleScope handle_scope(isolate);
367368
auto context = env->context();
368369

@@ -512,7 +513,7 @@ class NodeInspectorClient : public V8InspectorClient {
512513
}
513514
}
514515

515-
void FatalException(Local<Value> error, Local<v8::Message> message) {
516+
void FatalException(Local<Value> error, Local<Message> message) {
516517
Isolate* isolate = env_->isolate();
517518
Local<Context> context = env_->context();
518519

@@ -762,7 +763,7 @@ void Agent::WaitForDisconnect() {
762763
}
763764
}
764765

765-
void Agent::FatalException(Local<Value> error, Local<v8::Message> message) {
766+
void Agent::FatalException(Local<Value> error, Local<Message> message) {
766767
if (!IsListening())
767768
return;
768769
client_->FatalException(error, message);
@@ -774,8 +775,8 @@ void Agent::PauseOnNextJavascriptStatement(const std::string& reason) {
774775
}
775776

776777
void Agent::RegisterAsyncHook(Isolate* isolate,
777-
v8::Local<v8::Function> enable_function,
778-
v8::Local<v8::Function> disable_function) {
778+
Local<Function> enable_function,
779+
Local<Function> disable_function) {
779780
enable_async_hook_function_.Reset(isolate, enable_function);
780781
disable_async_hook_function_.Reset(isolate, disable_function);
781782
if (pending_enable_async_hook_) {
@@ -850,7 +851,7 @@ void Agent::RequestIoThreadStart() {
850851
// continuous JS code) and to wake up libuv thread (in case Node is waiting
851852
// for IO events)
852853
uv_async_send(&start_io_thread_async);
853-
v8::Isolate* isolate = parent_env_->isolate();
854+
Isolate* isolate = parent_env_->isolate();
854855
v8::Platform* platform = parent_env_->isolate_data()->platform();
855856
platform->CallOnForegroundThread(isolate, new StartIoTask(this));
856857
isolate->RequestInterrupt(StartIoInterrupt, this);

0 commit comments

Comments
 (0)