net: make stdout & stderr block on all platforms

Fixes: #784

Author: Fishrock123

lib/net.js

@@ -125,9 +125,7 @@ function Socket(options) {
     this._handle = createHandle(options.fd);
     this._handle.open(options.fd);
     if ((options.fd == 1 || options.fd == 2) &&
-        (this._handle instanceof Pipe) &&
-        process.platform === 'win32') {
-      // Make stdout and stderr blocking on Windows
+        this._handle instanceof Pipe) {
       var err = this._handle.setBlocking(true);
       if (err)
         throw errnoException(err, 'setBlocking');

test/fixtures/stdout-producer.js

@@ -0,0 +1,13 @@
+'use strict';
+
+const add = 'test\n';
+
+var str = '';
+for (var i = 0; i < 1e5; i++) {
+  str += add;
+}
+
+str += 'hey\n';
+
+process.stdout.write(str);
+process.exit();

test/parallel/test-child-process-chunked-stdout.js

@@ -0,0 +1,27 @@
+'use strict';
+
+const common = require('../common');
+const assert = require('assert');
+const fork = require('child_process').fork;
+const stream = require('stream');
+const path = require('path');
+
+const producer = fork(path.join(common.fixturesDir, 'stdout-producer.js'),
+                      { silent: true });
+
+var found = '';
+const writable = new stream.Writable({
+  write(chunk, _, next) {
+    const lines = chunk.toString().split('\n');
+
+    found = lines[lines.length - 2];
+    next();
+  }
+});
+
+producer.stdout.pipe(writable);
+producer.stdout.on('close', function() {
+  assert.strictEqual(found, 'hey');
+});
+
+producer.stderr.pipe(process.stderr);