Skip to content

Commit ac7184d

Browse files
sokratargos
authored andcommitted
http: clean up HttpParser correctly
Remove reference to kOnMessageBegin from HttpParser to avoid leaking Server instances in FreeList. PR-URL: #39292 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
1 parent 165130a commit ac7184d

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

Diff for: lib/_http_common.js

+2
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ let debug = require('internal/util/debuglog').debuglog('http', (fn) => {
4646

4747
const kIncomingMessage = Symbol('IncomingMessage');
4848
const kRequestTimeout = Symbol('RequestTimeout');
49+
const kOnMessageBegin = HTTPParser.kOnMessageBegin | 0;
4950
const kOnHeaders = HTTPParser.kOnHeaders | 0;
5051
const kOnHeadersComplete = HTTPParser.kOnHeadersComplete | 0;
5152
const kOnBody = HTTPParser.kOnBody | 0;
@@ -239,6 +240,7 @@ function cleanParser(parser) {
239240
parser.incoming = null;
240241
parser.outgoing = null;
241242
parser.maxHeaderPairs = MAX_HEADER_PAIRS;
243+
parser[kOnMessageBegin] = null;
242244
parser[kOnExecute] = null;
243245
parser[kOnTimeout] = null;
244246
parser._consumed = false;

0 commit comments

Comments
 (0)