Skip to content

Commit acfb724

Browse files
BridgeARtargos
authored andcommitted
test: remove harmony flags
v8 6.8 supports all removed flags. For example for BigInt. PR-URL: #22285 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent e9ac683 commit acfb724

7 files changed

+10
-27
lines changed

doc/api/util.md

+2-8
Original file line numberDiff line numberDiff line change
@@ -1026,10 +1026,7 @@ added: v10.0.0
10261026
* `value` {any}
10271027
* Returns: {boolean}
10281028

1029-
Returns `true` if the value is a `BigInt64Array` instance. The
1030-
`--harmony-bigint` command line flag is required in order to use the
1031-
`BigInt64Array` type, but it is not required in order to use
1032-
`isBigInt64Array()`.
1029+
Returns `true` if the value is a `BigInt64Array` instance.
10331030

10341031
For example:
10351032

@@ -1046,10 +1043,7 @@ added: v10.0.0
10461043
* `value` {any}
10471044
* Returns: {boolean}
10481045

1049-
Returns `true` if the value is a `BigUint64Array` instance. The
1050-
`--harmony-bigint` command line flag is required in order to use the
1051-
`BigUint64Array` type, but it is not required in order to use
1052-
`isBigUint64Array()`.
1046+
Returns `true` if the value is a `BigUint64Array` instance.
10531047

10541048
For example:
10551049

src/node.cc

-4
Original file line numberDiff line numberDiff line change
@@ -2974,10 +2974,6 @@ static void ParseArgs(int* argc,
29742974
config_preserve_symlinks_main = true;
29752975
} else if (strcmp(arg, "--experimental-modules") == 0) {
29762976
config_experimental_modules = true;
2977-
new_v8_argv[new_v8_argc] = "--harmony-dynamic-import";
2978-
new_v8_argc += 1;
2979-
new_v8_argv[new_v8_argc] = "--harmony-import-meta";
2980-
new_v8_argc += 1;
29812977
} else if (strcmp(arg, "--experimental-vm-modules") == 0) {
29822978
config_experimental_vm_modules = true;
29832979
} else if (strcmp(arg, "--experimental-worker") == 0) {

test/parallel/test-util-inspect-bigint.js

-12
This file was deleted.

test/parallel/test-util-inspect.js

+5
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ const JSStream = process.binding('js_stream').JSStream;
2626
const util = require('util');
2727
const vm = require('vm');
2828
const { previewEntries } = process.binding('util');
29+
const { inspect } = util;
2930

3031
assert.strictEqual(util.inspect(1), '1');
3132
assert.strictEqual(util.inspect(false), 'false');
@@ -1672,3 +1673,7 @@ util.inspect(process);
16721673
value.foo = 'bar';
16731674
assert.notStrictEqual(util.inspect(value), expected);
16741675
});
1676+
1677+
assert.strictEqual(inspect(1n), '1n');
1678+
assert.strictEqual(inspect(Object(-1n)), '[BigInt: -1n]');
1679+
assert.strictEqual(inspect(Object(13n)), '[BigInt: 13n]');

test/parallel/test-util-types.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Flags: --harmony-bigint --experimental-vm-modules
1+
// Flags: --experimental-vm-modules
22
'use strict';
33
require('../common');
44
const fixtures = require('../common/fixtures');

test/parallel/test-vm-module-dynamic-import.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use strict';
22

3-
// Flags: --experimental-vm-modules --experimental-modules --harmony-dynamic-import
3+
// Flags: --experimental-vm-modules --experimental-modules
44

55
const common = require('../common');
66

test/parallel/test-vm-module-import-meta.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use strict';
22

3-
// Flags: --experimental-vm-modules --harmony-import-meta
3+
// Flags: --experimental-vm-modules
44

55
const common = require('../common');
66
const assert = require('assert');

0 commit comments

Comments
 (0)