Skip to content

Commit ad41c91

Browse files
authored
src: remove v8abbr.h
The definitions in v8abbr.h, except for NODE_OFF_EXTSTR_DATA, were only used for dtrace, which has been removed. Refs: #43652 PR-URL: #44402 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
1 parent 3303a10 commit ad41c91

File tree

4 files changed

+8
-129
lines changed

4 files changed

+8
-129
lines changed

.github/label-pr-config.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ subSystemLabels:
2121
/^src\/tty_/: c++, tty
2222
/^src\/node_url/: c++, whatwg-url
2323
/^src\/node_util/: c++, util
24-
/^src\/(?:node_v8|v8abbr)/: c++, v8 engine
24+
/^src\/node_v8/: c++, v8 engine
2525
/^src\/node_contextify/: c++, vm
2626
/^src\/.*win32.*/: c++, windows
2727
/^src\/node_zlib/: c++, zlib

src/node_postmortem_metadata.cc

+5-4
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
1-
#include "env.h"
21
#include "base_object-inl.h"
2+
#include "env.h"
33
#include "handle_wrap.h"
4-
#include "util-inl.h"
5-
#include "req_wrap.h"
6-
#include "v8abbr.h"
74
#include "node_context_data.h"
5+
#include "req_wrap.h"
6+
#include "util-inl.h"
7+
8+
#define NODE_OFF_EXTSTR_DATA sizeof(void*)
89

910
#define NODEDBG_SYMBOL(Name) nodedbg_ ## Name
1011

src/v8abbr.h

-123
This file was deleted.

test/cctest/test_node_postmortem_metadata.cc

+2-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@
55
#include "req_wrap-inl.h"
66
#include "tracing/agent.h"
77
#include "v8.h"
8-
#include "v8abbr.h"
8+
9+
#define NODE_OFF_EXTSTR_DATA sizeof(void*)
910

1011
extern "C" {
1112
extern uintptr_t

0 commit comments

Comments
 (0)