Skip to content

Commit ad8fce6

Browse files
ryzokukendanielleadams
authored andcommittedOct 6, 2020
tools: update gyp to v0.4.0
PR-URL: #32698 Reviewed-By: Christian Clauss <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
1 parent 3e75907 commit ad8fce6

File tree

4 files changed

+22
-5
lines changed

4 files changed

+22
-5
lines changed
 

‎tools/gyp/CHANGELOG.md

+10-1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,14 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
66

77
## [Unreleased]
88

9+
## [0.4.0] - 2020-07-14
10+
11+
### Added
12+
- Added support for passing arbitrary architectures to Xcode builds, enables `arm64` builds.
13+
14+
### Fixed
15+
- Fixed a bug on Solaris where copying archives failed.
16+
917
## [0.3.0] - 2020-06-06
1018

1119
### Added
@@ -26,7 +34,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
2634
This is the first release of this project, based on https://chromium.googlesource.com/external/gyp
2735
with changes made over the years in Node.js and node-gyp.
2836

29-
[Unreleased]: https://github.com/nodejs/gyp-next/compare/v0.3.0...HEAD
37+
[Unreleased]: https://github.com/nodejs/gyp-next/compare/v0.4.0...HEAD
38+
[0.4.0]: https://github.com/nodejs/gyp-next/compare/v0.3.0...v0.4.0
3039
[0.3.0]: https://github.com/nodejs/gyp-next/compare/v0.2.1...v0.3.0
3140
[0.2.1]: https://github.com/nodejs/gyp-next/compare/v0.2.0...v0.2.1
3241
[0.2.0]: https://github.com/nodejs/gyp-next/releases/tag/v0.2.0

‎tools/gyp/pylib/gyp/generator/make.py

+10-2
Original file line numberDiff line numberDiff line change
@@ -1342,7 +1342,7 @@ def WriteSources(
13421342
)
13431343

13441344
if self.flavor == "mac":
1345-
cflags = self.xcode_settings.GetCflags(configname)
1345+
cflags = self.xcode_settings.GetCflags(configname, arch=config.get('xcode_configuration_platform'))
13461346
cflags_c = self.xcode_settings.GetCflagsC(configname)
13471347
cflags_cc = self.xcode_settings.GetCflagsCC(configname)
13481348
cflags_objc = self.xcode_settings.GetCflagsObjC(configname)
@@ -1637,6 +1637,7 @@ def WriteTarget(
16371637
configname,
16381638
generator_default_variables["PRODUCT_DIR"],
16391639
lambda p: Sourceify(self.Absolutify(p)),
1640+
arch=config.get('xcode_configuration_platform')
16401641
)
16411642

16421643
# TARGET_POSTBUILDS_$(BUILDTYPE) is added to postbuilds later on.
@@ -2362,7 +2363,14 @@ def CalculateMakefilePath(build_file, base_name):
23622363
}
23632364
)
23642365
elif flavor == "solaris":
2365-
header_params.update({"flock": "./gyp-flock-tool flock", "flock_index": 2})
2366+
copy_archive_arguments = "-pPRf@"
2367+
header_params.update(
2368+
{
2369+
"copy_archive_args": copy_archive_arguments,
2370+
"flock": "./gyp-flock-tool flock",
2371+
"flock_index": 2
2372+
}
2373+
)
23662374
elif flavor == "freebsd":
23672375
# Note: OpenBSD has sysutils/flock. lockf seems to be FreeBSD specific.
23682376
header_params.update({"flock": "lockf"})

‎tools/gyp/pylib/gyp/generator/ninja.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ def QuoteShellArgument(arg, flavor):
7878
"""Quote a string such that it will be interpreted as a single argument
7979
by the shell."""
8080
# Rather than attempting to enumerate the bad shell characters, just
81-
# whitelist common OK ones and quote anything else.
81+
# allow common OK ones and quote anything else.
8282
if re.match(r"^[a-zA-Z0-9_=.\\/-]+$", arg):
8383
return arg # No quoting necessary.
8484
if flavor == "win":

‎tools/gyp/setup.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
setup(
1717
name="gyp-next",
18-
version="0.3.0",
18+
version="0.4.0",
1919
description="A fork of the GYP build system for use in the Node.js projects",
2020
long_description=long_description,
2121
long_description_content_type="text/markdown",

0 commit comments

Comments
 (0)
Please sign in to comment.