Skip to content

Commit ada3f34

Browse files
maclover7targos
authored andcommitted
test: fix weird string error
Previously getting this error when running `tap2junit` (what parses our `.tap` files in CI): ``` Traceback (most recent call last): File "/usr/local/bin/tap2junit", line 11, in <module> sys.exit(main()) File "/usr/local/lib/python2.7/site-packages/tap2junit/__main__.py", line 46, in main result.to_file(args.output, [result], prettyprint=False) File "/usr/local/lib/python2.7/site-packages/junit_xml/__init__.py", line 289, in to_file test_suites, prettyprint=prettyprint, encoding=encoding) File "/usr/local/lib/python2.7/site-packages/junit_xml/__init__.py", line 257, in to_xml_string ts_xml = ts.build_xml_doc(encoding=encoding) File "/usr/local/lib/python2.7/site-packages/junit_xml/__init__.py", line 221, in build_xml_doc attrs['message'] = decode(case.skipped_message, encoding) File "/usr/local/lib/python2.7/site-packages/junit_xml/__init__.py", line 68, in decode ret = unicode(var) UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 11: ordinal not in range(128) ``` PR-URL: #21793 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent 712809e commit ada3f34

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

test/parallel/test-stdio-pipe-access.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22
const common = require('../common');
33
if (!common.isMainThread)
4-
common.skip('Workers dont have process-like stdio');
4+
common.skip("Workers don't have process-like stdio");
55

66
// Test if Node handles acessing process.stdin if it is a redirected
77
// pipe without deadlocking

test/parallel/test-stdio-pipe-redirect.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22
const common = require('../common');
33
if (!common.isMainThread)
4-
common.skip('Workers dont have process-like stdio');
4+
common.skip("Workers don't have process-like stdio");
55

66
// Test if Node handles redirecting one child process stdout to another
77
// process stdin without crashing.

0 commit comments

Comments
 (0)