Skip to content

Commit ae2eff2

Browse files
thefourtheyeMylesBorins
authored andcommitted
build: start comments at beginning of line
As the comments are indented in Makefile, they are actually echoed on the screen. This patch makes sure that the comments actually start at the beginning of the line, and so not echoed and ignored. PR-URL: #9375 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 80a7527 commit ae2eff2

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

Makefile

+5-5
Original file line numberDiff line numberDiff line change
@@ -147,8 +147,8 @@ ADDONS_BINDING_GYPS := \
147147
test/addons/.buildstamp: config.gypi \
148148
deps/npm/node_modules/node-gyp/package.json \
149149
$(ADDONS_BINDING_GYPS) test/addons/.docbuildstamp
150-
# Cannot use $(wildcard test/addons/*/) here, it's evaluated before
151-
# embedded addons have been generated from the documentation.
150+
# Cannot use $(wildcard test/addons/*/) here, it's evaluated before
151+
# embedded addons have been generated from the documentation.
152152
for dirname in test/addons/*/; do \
153153
$(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \
154154
--python="$(PYTHON)" \
@@ -237,15 +237,15 @@ test-timers-clean:
237237
$(MAKE) --directory=tools clean
238238

239239
test-v8: v8
240-
# note: performs full test unless QUICKCHECK is specified
240+
# note: performs full test unless QUICKCHECK is specified
241241
deps/v8/tools/run-tests.py --arch=$(V8_ARCH) \
242242
--mode=$(BUILDTYPE_LOWER) $(V8_TEST_NO_I18N) $(QUICKCHECK_ARG) \
243243
--no-presubmit \
244244
--shell-dir=$(PWD)/deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) \
245245
$(TAP_V8)
246246

247247
test-v8-intl: v8
248-
# note: performs full test unless QUICKCHECK is specified
248+
# note: performs full test unless QUICKCHECK is specified
249249
deps/v8/tools/run-tests.py --arch=$(V8_ARCH) \
250250
--mode=$(BUILDTYPE_LOWER) --no-presubmit $(QUICKCHECK_ARG) \
251251
--shell-dir=deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) intl \
@@ -258,7 +258,7 @@ test-v8-benchmarks: v8
258258
$(TAP_V8_BENCHMARKS)
259259

260260
test-v8-all: test-v8 test-v8-intl test-v8-benchmarks
261-
# runs all v8 tests
261+
# runs all v8 tests
262262

263263
apidoc_sources = $(wildcard doc/api/*.md)
264264
apidocs_html = $(apidoc_dirs) $(apiassets) $(addprefix out/,$(apidoc_sources:.md=.html))

0 commit comments

Comments
 (0)