Skip to content

Commit afc811c

Browse files
addaleaxMylesBorins
authored andcommitted
src: break out of timers loop if !can_call_into_js()
Otherwise, this turns into an infinite loop when the flag is set, because it makes `MakeCallback()` return immediately. Backport-PR-URL: #21168 PR-URL: #20884 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
1 parent 2c671ab commit afc811c

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

src/timer_wrap.cc

+1
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,7 @@ class TimerWrap : public HandleWrap {
148148
.ToLocalChecked();
149149
} while (ret->IsUndefined() &&
150150
!env->tick_info()->has_thrown() &&
151+
env->can_call_into_js() &&
151152
wrap->object()->Get(env->context(),
152153
env->owner_string()).ToLocalChecked()
153154
->IsUndefined());

0 commit comments

Comments
 (0)