Skip to content

Commit b044256

Browse files
Trotttargos
authored andcommitted
build: use LC_ALL of C for maximum compatibility
LC_ALL=en_US breaks on some systems (notably the SmartOS 16 configuration in our CI). Use LC_ALL=C instead. PR-URL: #21222 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 4e742e3 commit b044256

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

configure

+1-4
Original file line numberDiff line numberDiff line change
@@ -672,10 +672,7 @@ def get_xcode_version(cc):
672672
def get_gas_version(cc):
673673
try:
674674
custom_env = os.environ.copy()
675-
# smartos (a.k.a. sunos5) does not have the en_US locale, and will give:
676-
# `setlocale: LC_ALL: cannot change locale (en_US): Invalid argument`
677-
if 'sunos' not in sys.platform:
678-
custom_env["LC_ALL"] = "en_US"
675+
custom_env["LC_ALL"] = "C"
679676
proc = subprocess.Popen(shlex.split(cc) + ['-Wa,-v', '-c', '-o',
680677
'/dev/null', '-x',
681678
'assembler', '/dev/null'],

0 commit comments

Comments
 (0)