Skip to content

Commit b0db2b9

Browse files
Eugene Ostroukhovaddaleax
Eugene Ostroukhov
authored andcommitted
inspector, test: Fix test bug detected by Coverity
Error value was not checked. Turns out, uv_ip6_addr was actually called on malformed IP (square brackets should not have been included). PR-URL: #13799 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent ebe7bb2 commit b0db2b9

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

test/cctest/test_inspector_socket_server.cc

+6-4
Original file line numberDiff line numberDiff line change
@@ -172,12 +172,14 @@ class SocketWrapper {
172172
contents_.clear();
173173
uv_tcp_init(loop_, &socket_);
174174
union {sockaddr generic; sockaddr_in v4; sockaddr_in6 v6;} addr;
175+
int err = 0;
175176
if (v6) {
176-
uv_ip6_addr(host.c_str(), port, &addr.v6);
177+
err = uv_ip6_addr(host.c_str(), port, &addr.v6);
177178
} else {
178-
uv_ip4_addr(host.c_str(), port, &addr.v4);
179+
err = uv_ip4_addr(host.c_str(), port, &addr.v4);
179180
}
180-
int err = uv_tcp_connect(&connect_, &socket_, &addr.generic, Connected_);
181+
ASSERT_EQ(0, err);
182+
err = uv_tcp_connect(&connect_, &socket_, &addr.generic, Connected_);
181183
ASSERT_EQ(0, err);
182184
SPIN_WHILE(!connected_)
183185
uv_read_start(reinterpret_cast<uv_stream_t*>(&socket_), AllocCallback,
@@ -618,7 +620,7 @@ TEST_F(InspectorSocketServerTest, BindsToIpV6) {
618620
ASSERT_TRUE(server->Start());
619621

620622
SocketWrapper socket1(&loop);
621-
socket1.Connect("[::]", server.port(), true);
623+
socket1.Connect("::", server.port(), true);
622624
socket1.Write(WsHandshakeRequest(MAIN_TARGET_ID));
623625
socket1.Expect(WS_HANDSHAKE_RESPONSE);
624626
server->Stop(ServerHolder::CloseCallback);

0 commit comments

Comments
 (0)