Skip to content

Commit b0e86ea

Browse files
committed
doc: update maintaining V8 guide
Replace references to the outdated `update-v8` tool to its replacement in `node-core-utils` PR-URL: #22913 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 00dd973 commit b0e86ea

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

doc/guides/maintaining-V8.md

+8-8
Original file line numberDiff line numberDiff line change
@@ -232,8 +232,8 @@ to be cherry-picked in the Node.js repository and V8-CI must test the change.
232232
`tools/make-v8.sh` to reconstruct a git tree in the `deps/v8` directory to
233233
run V8 tests.
234234

235-
The [`update-v8`] tool can be used to simplify this task. Run
236-
`update-v8 backport --sha=SHA` to cherry-pick a commit.
235+
The [`git-node`] tool can be used to simplify this task. Run
236+
`git node v8 backport <sha>` to cherry-pick a commit.
237237

238238
An example for workflow how to cherry-pick consider the bug
239239
[RegExp show inconsistent result with other browsers](https://crbug.com/v8/5199).
@@ -341,8 +341,8 @@ curl -L https://github.com/v8/v8/compare/${V8_OLD_VERSION}...${V8_NEW_VERSION}.p
341341
V8 also keeps tags of the form *5.4-lkgr* which point to the *Last Known Good
342342
Revision* from the 5.4 branch that can be useful in the update process above.
343343

344-
The [`update-v8`](https://github.com/targos/update-v8) tool can be used to
345-
simplify this task. Run `update-v8 minor` to apply a minor update.
344+
The [`git-node`] tool can be used to simplify this task. Run `git node v8 minor`
345+
to apply a minor update.
346346

347347
### Major Updates
348348

@@ -368,13 +368,13 @@ To audit for floating patches:
368368
git log --oneline deps/v8
369369
```
370370

371-
To replace the copy of V8 in Node.js, use the [`update-v8`] tool. For example,
372-
if you want to replace the copy of V8 in Node.js with the branch-head for V8 5.1
371+
To replace the copy of V8 in Node.js, use the [`git-node`] tool. For example, if
372+
you want to replace the copy of V8 in Node.js with the branch-head for V8 5.1
373373
branch:
374374

375375
```shell
376376
cd $NODE_DIR
377-
update-v8 major --branch=5.1-lkgr
377+
git node v8 major --branch=5.1-lkgr
378378
```
379379

380380
This should be followed up with manual refloating of all relevant patches.
@@ -422,7 +422,7 @@ as their support has ended.
422422
[NodeJS-Backport-Rejected-V8]: https://bugs.chromium.org/p/v8/issues/list?can=1&q=label%3ANodeJS-Backport-Rejected
423423
[NodeJS-Backport-Review-Chromium]: https://bugs.chromium.org/p/chromium/issues/list?can=1&q=label%3ANodeJS-Backport-Review
424424
[NodeJS-Backport-Review-V8]: https://bugs.chromium.org/p/v8/issues/list?can=1&q=label%3ANodeJS-Backport-Review
425-
[`update-v8`]: https://github.com/targos/update-v8
425+
[`git-node`]: https://github.com/nodejs/node-core-utils/blob/master/docs/git-node.md#git-node-v8
426426
[V8 CI]: https://ci.nodejs.org/job/node-test-commit-v8-linux/
427427
[V8ActiveBranches]: https://build.chromium.org/p/client.v8.branches/console
428428
[V8Contributing]: https://github.com/v8/v8/wiki/Contributing

0 commit comments

Comments
 (0)