Skip to content

Commit b2936cf

Browse files
pi1024etargos
pi1024e
authored andcommitted
src: organize imports in inspector_profiler.cc
In the other .cc files in the project, includes are in alphabetical order, with local files first, and libraries after. However, inspector_profiler.cc has a library declared in the middle of the import order, and v8 is the second to last being imported, instead of the last. So I reordered the imports and testing showed no side effects; everything passed. PR-URL: #29073 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
1 parent 13a4979 commit b2936cf

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

src/inspector_profiler.cc

+4-3
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
#include "inspector_profiler.h"
2-
#include <sstream>
32
#include "base_object-inl.h"
43
#include "debug_utils.h"
54
#include "diagnosticfilename-inl.h"
65
#include "memory_tracker-inl.h"
76
#include "node_file.h"
87
#include "node_internals.h"
9-
#include "v8-inspector.h"
108
#include "util-inl.h"
9+
#include "v8-inspector.h"
10+
11+
#include <sstream>
1112

1213
namespace node {
1314
namespace profiler {
@@ -323,7 +324,7 @@ void EndStartedProfilers(Environment* env) {
323324
std::string GetCwd(Environment* env) {
324325
char cwd[PATH_MAX_BYTES];
325326
size_t size = PATH_MAX_BYTES;
326-
int err = uv_cwd(cwd, &size);
327+
const int err = uv_cwd(cwd, &size);
327328

328329
if (err == 0) {
329330
CHECK_GT(size, 0);

0 commit comments

Comments
 (0)