Skip to content

Commit b3a7a68

Browse files
ShogunPandatargos
authored andcommitted
doc: document breaking change in http.IncomingMessage 'close' event
PR-URL: #42521 Fixes: #38924 Refs: #33035 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
1 parent 4ffc088 commit b3a7a68

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

doc/api/http.md

+6-1
Original file line numberDiff line numberDiff line change
@@ -2102,9 +2102,14 @@ Emitted when the request has been aborted.
21022102

21032103
<!-- YAML
21042104
added: v0.4.2
2105+
changes:
2106+
- version: v16.0.0
2107+
pr-url: https://github.com/nodejs/node/pull/33035
2108+
description: The close event is now emitted when the request has been completed and not when the
2109+
underlying socket is closed.
21052110
-->
21062111

2107-
Indicates that the underlying connection was closed.
2112+
Emitted when the request has been completed.
21082113

21092114
### `message.aborted`
21102115

doc/changelogs/CHANGELOG_V16.md

+1
Original file line numberDiff line numberDiff line change
@@ -2801,6 +2801,7 @@ Contributed by Michaël Zasso - [#37587](https://github.com/nodejs/node/pull/375
28012801
* **deps**: update llhttp to 6.0.0 (Fedor Indutny) [#38277](https://github.com/nodejs/node/pull/38277)
28022802
* **deps**: upgrade npm to 7.10.0 (Ruy Adorno) [#38254](https://github.com/nodejs/node/pull/38254)
28032803
* **(SEMVER-MINOR)** **http**: add http.ClientRequest.getRawHeaderNames() (simov) [#37660](https://github.com/nodejs/node/pull/37660)
2804+
* **(SEMVER-MAJOR)** **http**: use `autoDestroy: true` in incoming message (Daniele Belardi) [#33035](https://github.com/nodejs/node/pull/33035)
28042805
* **(SEMVER-MAJOR)** **lib,src**: update cluster to use Parent (Michael Dawson) [#36478](https://github.com/nodejs/node/pull/36478)
28052806
* **(SEMVER-MINOR)** **module**: add support for `node:`‑prefixed `require(…)` calls (ExE Boss) [#37246](https://github.com/nodejs/node/pull/37246)
28062807
* **(SEMVER-MINOR)** **perf\_hooks**: add histogram option to timerify (James M Snell) [#37475](https://github.com/nodejs/node/pull/37475)

0 commit comments

Comments
 (0)