Skip to content

Commit b3f2e3b

Browse files
committed
tools: replace custom assert.fail lint rule
Replace custom lint rule for `assert.fail()` function signature errors with a restricted-syntax rule. PR-URL: #12287 Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 0ec0272 commit b3f2e3b

File tree

2 files changed

+3
-31
lines changed

2 files changed

+3
-31
lines changed

.eslintrc.yaml

+3-1
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,9 @@ rules:
110110
}, {
111111
selector: "ThrowStatement > CallExpression[callee.name=/Error$/]",
112112
message: "Use new keyword when throwing an Error."
113+
}, {
114+
selector: "CallExpression[callee.object.name='assert'][callee.property.name='fail'][arguments.length=1]",
115+
message: "assert.fail() message should be third argument"
113116
}]
114117
no-tabs: 2
115118
no-trailing-spaces: 2
@@ -142,7 +145,6 @@ rules:
142145

143146
# Custom rules in tools/eslint-rules
144147
align-multiline-assignment: 2
145-
assert-fail-single-argument: 2
146148
assert-throws-arguments: [2, { requireTwo: false }]
147149
no-unescaped-regexp-dot: 2
148150

tools/eslint-rules/assert-fail-single-argument.js

-30
This file was deleted.

0 commit comments

Comments
 (0)