Skip to content

Commit b4ba4af

Browse files
joshgavMylesBorins
authored andcommitted
doc: add CTC meeting minutes 2016-09-07
PR-URL: #8499 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 4b49b0e commit b4ba4af

File tree

1 file changed

+245
-0
lines changed

1 file changed

+245
-0
lines changed

doc/ctc-meetings/2016-09-07.md

+245
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,245 @@
1+
# Node Foundation CTC Meeting 2016-09-07
2+
3+
## Links
4+
5+
* **Audio Recording**: TBP
6+
* **GitHub Issue**: [#8425](https://github.com/nodejs/node/issues/8425)
7+
* **Minutes Google Doc**: <https://docs.google.com/document/d/1GRgBC5Dv5luqlRc6egtxmkrQULJXa3M3CqGqWfoogV8>
8+
* _Previous Minutes Google Doc_: <https://docs.google.com/document/d/1qYUOfiiytaZ0-YZVZ1NZX9O-4SE28QNooapOdcjlPqA>
9+
10+
## Present
11+
12+
* Anna Henningsen @addaleax (CTC)
13+
* Bradley Meck @bmeck (observer/GoDaddy/TC39)
14+
* Сковорода Никита Андреевич @ChALkeR (CTC)
15+
* Evan Lucas @evanlucas (CTC)
16+
* Jeremiah Senkpiel @Fishrock123 (CTC)
17+
* Tracy Hinds @hackygolucky (observer/Node.js Foundation)
18+
* Josh Gavant @joshgav (observer/Microsoft)
19+
* Michael Dawson @mhdawson (CTC)
20+
* Julien Gilli @misterdjules (CTC)
21+
* Ali Ijaz Sheikh @ofrobots (CTC)
22+
* Rod Vagg @rvagg (CTC)
23+
* Seth Thompson @s3ththompson (observer/Google)
24+
* Steven R Loomis @srl295 (observer/IBM/ICU)
25+
* Myles Borins @TheAlphaNerd (CTC)
26+
* Trevor Norris @trevnorris (CTC)
27+
* Rich Trott @Trott (CTC)
28+
29+
## Standup
30+
31+
* Anna Henningsen @addaleax (CTC)
32+
* Issues & PR review
33+
* Bradley Meck @bmeck (observer/GoDaddy/TC39)
34+
* Just emails around modules
35+
* Сковорода Никита Андреевич @ChALkeR (CTC)
36+
* Some private ecosystem things
37+
* Evan Lucas @evanlucas (CTC)
38+
* opened PR for adding back --harmony-proxies flag, not much else
39+
* Jeremiah Senkpiel @Fishrock123 (CTC)
40+
* Working on v6.6.0
41+
* issue & PRs, Async_Wrap review, some Timers PRs.
42+
* Fedor Indutny @indutny (CTC)
43+
* Reviewing PRs & Fixing bugs (sorry for not joining you today)
44+
* Josh Gavant @joshgav (observer/Microsoft)
45+
* Issues and PRs
46+
* Michael Dawson @mhdawson (CTC)
47+
* Investigating and PRs to move AIX to green in CI
48+
* Migration to new set of PPC machines
49+
* Addition of linuxOne to nightlies
50+
* Moved API work to nodejs/abi-stable-nodenodejs/abi-stable-node-addons-examples
51+
* presentations for Node Interactive EU
52+
* Brian White @mscdex (CTC)
53+
* Worked on finding improvements in http code
54+
* Commented on issues, reviewed PRs
55+
* Ali Ijaz Sheikh @ofrobots (CTC)
56+
* Wrangle some V8 backports.
57+
* Looking at performance w/ new ignition interpreter
58+
* Rod Vagg @rvagg (CTC)
59+
* Raspberry Pi cluster hardware problems, blog post
60+
* Seth Thompson @s3ththompson (observer/Google)
61+
* V8 team working on Ignition interpreter and V8 Inspector migration
62+
* Steven R Loomis @srl295 (observer/IBM/ICU)
63+
* PRs.
64+
* Myles Borins @TheAlphaNerd (CTC)
65+
* Auditing commits for v4.x
66+
* Modifying output of testrunner
67+
* preparing for interactive EU
68+
* Trevor Norris @trevnorris (CTC)
69+
* AsyncHook (formerly known as AsyncWrap); update embedder API to improve performance
70+
* Rich Trott @Trott (CTC)
71+
* Backporting a few small commits to v4.x
72+
* Updating Build and Onboarding docs based on contributor mentoring and onboarding activities
73+
* A few test PRs designed to increase test coverage
74+
75+
76+
## Agenda
77+
78+
Extracted from **ctc-agenda** labelled issues and pull requests from the **nodejs org** prior to the meeting.
79+
80+
### nodejs/node
81+
82+
* src: add no-op for --harmony-proxies flag [#8395](https://github.com/nodejs/node/pull/8395)
83+
84+
### nodejs/node-eps
85+
86+
* AsyncWrap public API proposal [#18](https://github.com/nodejs/node-eps/pull/18)
87+
88+
89+
## Previous Meeting Review
90+
91+
* Process for determining supported platforms [#8265](https://github.com/nodejs/node/issues/8265)
92+
* Build WG will prepare initial list of supported platforms in their next meeting.
93+
* Then CTC will review and decide next steps.
94+
95+
* child_process, win: fix shell spawn with AutoRun [#8063](https://github.com/nodejs/node/pull/8063)
96+
* Remove from CTC agenda.
97+
* @joshgav to check for opinions within Microsoft.
98+
* Ask @joaocgreis in GitHub for more explanation.
99+
100+
* fs: undeprecate existsSync; use access instead of stat for performance [#7455](https://github.com/nodejs/node/pull/7455)
101+
* @trott to ping nodejs/collaborators in that thread. If no response then [fix].
102+
103+
* doc: add Google Analytics tracking. [#6601](https://github.com/nodejs/node/pull/6601)
104+
* Merge!
105+
106+
* Introduce staging branch for stable release streams [#6306](https://github.com/nodejs/node/issues/6306)
107+
* Do this as proposed.
108+
109+
* Move ecosystem detection tool to nodejs org [#7935](https://github.com/nodejs/node/issues/7935)
110+
* Prep repo for migration.
111+
* Open issue in nodejs/tsc.
112+
113+
* AsyncWrap public API proposal [#18](https://github.com/nodejs/node-eps/pull/18)
114+
* Trevor to update all code and ask for vote on specific item(s).
115+
* CTC to review again once complete.
116+
117+
118+
## Minutes
119+
120+
### src: add no-op for --harmony-proxies flag [#8395](https://github.com/nodejs/node/pull/8395)
121+
122+
We upgraded to V8 5.1 in v6.5. That removed several flags, notably the --harmony-* flags. Many in the ecosystem have hard-coded these flags and as a result are getting errors since v6.5.
123+
124+
@evanlucas added a PR to no-op those flags. There was quite a bit of resistance to that, as it implies that we apply semver semantics to experimental features.
125+
126+
@addaleax: Does anyone have concrete reason to not no-op these flags?
127+
128+
@trott: For clarity, do we mean to no-op them till the next semver-major release?
129+
130+
@addaleax: Yes.
131+
132+
@Fishrock123: This would only ever land in v6.
133+
134+
@evanlucas: Some feel this should be floated on V8.
135+
136+
@trevnorris: Could they?
137+
138+
@ofrobots: Trivial to do it, but this is on 5.1 which is an abandoned upstream.
139+
140+
@trevnorris: We were told we could re-open abandoned branches?
141+
142+
@ofrobots: That’s correct.
143+
144+
@? : Were the flags removed because their behavior is V8's default?
145+
146+
@ofrobots: Yes, support was already there but flags had not yet been removed.
147+
148+
@? : Other flags were removed too.
149+
150+
@addaleax: Main issue is the --harmony flags, I haven’t seen the other flags as issues.
151+
152+
@ofrobots: I’m supportive of adding no-ops for --harmony flags cause they break the ecosystem. Others no.
153+
154+
@Fishrock123: What about strong mode flags?
155+
156+
@ofrobots: Mainstream users are not likely to be using strong mode flags.
157+
158+
@ofrobots: The ones recommended as no-ops I agree should be added back as no-ops.
159+
160+
@rvagg: We can adopt a new policy if we want, for example state that when we upgrade V8 flags may change and you have to do feature detection to address that.
161+
162+
@addaleax: Seems to be that’s what some people want in comments, but it seems that it might not be what people expect.
163+
164+
@rvagg: Many flags unlikely to be used in real code, but some may be used in production code. Ones that are potentially usable in production code, sure.
165+
166+
@trevnorris: Let’s re-add the no-ops and see if people raise issues about the others.
167+
It would be more pure to backport in V8, but I don’t see why floating it in Node would be an issue.
168+
169+
@addaleax: @bnoordhuis was strongly -1 on floating a patch on V8, but didn’t give a reason.
170+
171+
@misterdjules: what do we mean by floating a patch?
172+
173+
@trevnorris: we don’t even have to let these through to V8, just catch it ourselves.
174+
175+
@Fishrock123: That would be harder.
176+
177+
@ChALkeR: perhaps warn in runtime on unsupported flags for next major?
178+
179+
@rvagg: Colin and Ben had negative positions.
180+
Is proposal to ask Ali to move forward in V8?
181+
182+
@addaleax: Not expecting a definite decision, hoping to hear from people who are -1. Would be happy if someone put together a PR with all the flags we want to no-op and discuss in next meeting if necessary.
183+
184+
@trev: How long to get a patch on the V8 branch?
185+
186+
@ofrobots: Probably not too long, dependent on me finding a half hour.
187+
This will be a patch we float on our downstream of V8 5.1. We are the de facto owners of this branch now.
188+
189+
@rvagg: Open a PR, move discussion there, people with negatives can expand on them there.
190+
191+
**Next steps**:
192+
193+
* @ofrobots to float a patch on our branch of V8 5.1 and open a PR. Discussion to continue there.
194+
* Keep on agenda for next week just in case.
195+
196+
197+
### AsyncWrap public API proposal [node-eps#18](https://github.com/nodejs/node-eps/pull/18)
198+
199+
@trevnorris: EP is near 100% ready, only thing likely to change is the native C++ API but after doing testing and implementation it’s where it needs to be for all of the goals set for it.
200+
201+
@rvagg: We need to sign off on the EP. Can’t do that today, right?
202+
203+
@trevnorris: No, but EP is there. I’ve updated it with code, examples, stuff like that.
204+
205+
@rvagg: Will there be changes in node-eps#18 between now and next week?
206+
207+
@trevnorris: No, unless some major change comes in.
208+
209+
@trevnorris: No docs yet, Bradley has volunteered.
210+
211+
@rvagg: There will eventually be a discussion of backporting to V4.
212+
213+
@trevnorris: Discussion continues on promise side.
214+
215+
@rvagg: cause we don’t have insight into the microtask queue?
216+
217+
@trevnorris: Yes. It’s proceeding.
218+
219+
@seththompson: V8 team is interested in helping with this. Looks like async/await won’t make cut for v7, gives us more time to work on the right thing here.
220+
221+
**Next steps**:
222+
223+
* Everyone read [node-eps#18](https://github.com/nodejs/node-eps/pull/18).
224+
* Vote next week on Node-EP.
225+
* Open a PR for implementation in nodejs/node.
226+
227+
228+
### Modules
229+
230+
@bmeck: There were several concerns about the rewritten EP for ES6 module compat. Note that we haven’t merged that yet, people are welcome to comment in that issue.
231+
232+
@rvagg: Those who are concerned should definitely get in touch with Bradley (@bmeck).
233+
234+
235+
## Q/A on public channels
236+
237+
* Thanks for the heads-up on async/await.
238+
239+
240+
## Upcoming Meetings
241+
242+
* CTC: 2016-09-14
243+
* TSC: 2016-09-08
244+
* Benchmarking: [Benchmarking#56](https://github.com/nodejs/benchmarking/issues/56)
245+
* Build: 2016-09-20

0 commit comments

Comments
 (0)