Skip to content

Commit b5802c7

Browse files
bnoordhuisaddaleax
authored andcommitted
src: avoid heap allocation in crypto.pbkdf2()
PR-URL: #14122 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 1c3e090 commit b5802c7

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/node_crypto.cc

+3-2
Original file line numberDiff line numberDiff line change
@@ -5355,8 +5355,9 @@ void PBKDF2Request::Work(uv_work_t* work_req) {
53555355
void PBKDF2Request::After(Local<Value> (*argv)[2]) {
53565356
if (error()) {
53575357
(*argv)[0] = Undefined(env()->isolate());
5358-
(*argv)[1] = Encode(env()->isolate(), key(), keylen(), BUFFER);
5359-
OPENSSL_cleanse(key(), keylen());
5358+
(*argv)[1] = Buffer::New(env(), key(), keylen()).ToLocalChecked();
5359+
key_ = nullptr;
5360+
keylen_ = 0;
53605361
} else {
53615362
(*argv)[0] = Exception::Error(env()->pbkdf2_error_string());
53625363
(*argv)[1] = Undefined(env()->isolate());

0 commit comments

Comments
 (0)