Skip to content

Commit b6cceae

Browse files
Laszlo.MoczoBethGriggs
Laszlo.Moczo
authored andcommitted
test: cover path.basename when path and ext are the same
In path.basename was a case when the path and the extension is the same and this wasn't covered with tests. I covered this case both in Windows and Unix environments. PR-URL: #24570 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
1 parent 7f0fb16 commit b6cceae

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

test/parallel/test-path-basename.js

+2
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ assert.strictEqual(path.basename('/aaa/'), 'aaa');
2929
assert.strictEqual(path.basename('/aaa/b'), 'b');
3030
assert.strictEqual(path.basename('/a/b'), 'b');
3131
assert.strictEqual(path.basename('//a'), 'a');
32+
assert.strictEqual(path.basename('a', 'a'), '');
3233

3334
// On Windows a backslash acts as a path separator.
3435
assert.strictEqual(path.win32.basename('\\dir\\basename.ext'), 'basename.ext');
@@ -53,6 +54,7 @@ assert.strictEqual(path.win32.basename('C:basename.ext\\'), 'basename.ext');
5354
assert.strictEqual(path.win32.basename('C:basename.ext\\\\'), 'basename.ext');
5455
assert.strictEqual(path.win32.basename('C:foo'), 'foo');
5556
assert.strictEqual(path.win32.basename('file:stream'), 'file:stream');
57+
assert.strictEqual(path.win32.basename('a', 'a'), '');
5658

5759
// On unix a backslash is just treated as any other character.
5860
assert.strictEqual(path.posix.basename('\\dir\\basename.ext'),

0 commit comments

Comments
 (0)