Skip to content

Commit b7338b7

Browse files
addaleaxrefack
authored andcommitted
deps: V8: cherry-pick f0bb5d2
Original commit message: [api] remove LegacyBuildEmbedderGraphCallback This should not be used anymore (and it definitely is not by Node.js or Chromium). Change-Id: I4a1ce1fda98efd197a64ce0969dae5c8b18f6e97 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1511484 Reviewed-by: Yang Guo <[email protected]> Commit-Queue: Yang Guo <[email protected]> Cr-Commit-Position: refs/heads/master@{#60139} Refs: v8/v8@f0bb5d2 PR-URL: #26685 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
1 parent 0217194 commit b7338b7

File tree

3 files changed

+1
-19
lines changed

3 files changed

+1
-19
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737

3838
# Reset this number to 0 on major V8 upgrades.
3939
# Increment by one for each non-official patch applied to deps/v8.
40-
'v8_embedder_string': '-node.4',
40+
'v8_embedder_string': '-node.5',
4141

4242
##### V8 defaults for Node.js #####
4343

deps/v8/include/v8-profiler.h

-8
Original file line numberDiff line numberDiff line change
@@ -756,10 +756,6 @@ class V8_EXPORT HeapProfiler {
756756
v8::EmbedderGraph* graph,
757757
void* data);
758758

759-
/** TODO(addaleax): Remove */
760-
typedef void (*LegacyBuildEmbedderGraphCallback)(v8::Isolate* isolate,
761-
v8::EmbedderGraph* graph);
762-
763759
/** Returns the number of snapshots taken. */
764760
int GetSnapshotCount();
765761

@@ -898,10 +894,6 @@ class V8_EXPORT HeapProfiler {
898894
*/
899895
void DeleteAllHeapSnapshots();
900896

901-
V8_DEPRECATED(
902-
"Use AddBuildEmbedderGraphCallback to provide info about embedder nodes",
903-
void SetBuildEmbedderGraphCallback(
904-
LegacyBuildEmbedderGraphCallback callback));
905897
void AddBuildEmbedderGraphCallback(BuildEmbedderGraphCallback callback,
906898
void* data);
907899
void RemoveBuildEmbedderGraphCallback(BuildEmbedderGraphCallback callback,

deps/v8/src/api.cc

-10
Original file line numberDiff line numberDiff line change
@@ -10443,16 +10443,6 @@ void HeapProfiler::DeleteAllHeapSnapshots() {
1044310443
reinterpret_cast<i::HeapProfiler*>(this)->DeleteAllSnapshots();
1044410444
}
1044510445

10446-
void HeapProfiler::SetBuildEmbedderGraphCallback(
10447-
LegacyBuildEmbedderGraphCallback callback) {
10448-
reinterpret_cast<i::HeapProfiler*>(this)->AddBuildEmbedderGraphCallback(
10449-
[](v8::Isolate* isolate, v8::EmbedderGraph* graph, void* data) {
10450-
reinterpret_cast<LegacyBuildEmbedderGraphCallback>(data)(isolate,
10451-
graph);
10452-
},
10453-
reinterpret_cast<void*>(callback));
10454-
}
10455-
1045610446
void HeapProfiler::AddBuildEmbedderGraphCallback(
1045710447
BuildEmbedderGraphCallback callback, void* data) {
1045810448
reinterpret_cast<i::HeapProfiler*>(this)->AddBuildEmbedderGraphCallback(

0 commit comments

Comments
 (0)